[ty] Make __getattr__ available for ModuleType instances
#21450
Merged
+44
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unresolved-attribute |
2 | 3,469 | 0 |
possibly-missing-attribute |
12 | 652 | 1 |
call-non-callable |
0 | 17 | 0 |
unused-ignore-comment |
12 | 0 | 0 |
invalid-argument-type |
0 | 6 | 0 |
invalid-assignment |
0 | 5 | 0 |
not-iterable |
0 | 2 | 0 |
invalid-return-type |
0 | 0 | 1 |
unsupported-operator |
0 | 1 | 0 |
| Total | 26 | 4,152 | 2 |
sharkdp
commented
Nov 14, 2025
| let custom_getattr_result = || { | ||
| // Typeshed has a fake `__getattr__` on `types.ModuleType` to help out with | ||
| // dynamic imports. We explicitly hide it here to prevent arbitrary attributes | ||
| // from being available on modules. Same for `types.GenericAlias` - its |
Contributor
Author
There was a problem hiding this comment.
I don't understand why the GenericAlias exception was here. No tests seem to fail when I remove it?
sharkdp
requested review from
AlexWaygood,
carljm and
dcreager
as code owners
AlexWaygood
approved these changes
Nov 14, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Approving just on the basis of this, of course
Member
|
Thank you! |
dcreager
added a commit
that referenced
this pull request
Nov 14, 2025
* origin/main: (59 commits) [ty] Improve diagnostic range for `non-subscriptable` diagnostics (#21461) [ty] Improve literal promotion heuristics (#21439) [ty] Further improve details around which expressions should be deferred in stub files (#21456) [ty] Improve generic class constructor inference (#21442) [ty] Propagate type context through conditional expressions (#21443) [ty] Suppress completions when introducing names with `as` [ty] Add panic-by-default await methods to `TestServer` (#21451) [ty] name is parameter and global is a syntax error (#21312) [ty] Fixup a few details around version-specific dataclass features (#21453) [ty] Support attribute-expression `TYPE_CHECKING` conditionals (#21449) [ty] Support stringified annotations in value-position `Annotated` instances (#21447) [ty] Type inference for genererator expressions (#21437) [ty] Make `__getattr__` available for `ModuleType` instances (#21450) [ty] Increase default receive timeout in tests to 10s (#21448) [ty] Add synthetic members to completions on dataclasses (#21446) [ty] Support legacy `typing` special forms in implicit type aliases (#21433) Bump 0.14.5 (#21435) [ty] Support `type[…]` and `Type[…]` in implicit type aliases (#21421) [ty] Respect notebook cell boundaries when adding an auto import (#21322) Update PyCharm setup instructions (#21409) ...
dcreager
added a commit
that referenced
this pull request
Nov 14, 2025
* dcreager/deep-comparison: (64 commits) assuming SubtypingAssuming implies_subtype_of name tweak Apply suggestions from code review [ty] Improve diagnostic range for `non-subscriptable` diagnostics (#21461) [ty] Improve literal promotion heuristics (#21439) [ty] Further improve details around which expressions should be deferred in stub files (#21456) [ty] Improve generic class constructor inference (#21442) [ty] Propagate type context through conditional expressions (#21443) [ty] Suppress completions when introducing names with `as` [ty] Add panic-by-default await methods to `TestServer` (#21451) [ty] name is parameter and global is a syntax error (#21312) [ty] Fixup a few details around version-specific dataclass features (#21453) [ty] Support attribute-expression `TYPE_CHECKING` conditionals (#21449) [ty] Support stringified annotations in value-position `Annotated` instances (#21447) [ty] Type inference for genererator expressions (#21437) [ty] Make `__getattr__` available for `ModuleType` instances (#21450) [ty] Increase default receive timeout in tests to 10s (#21448) [ty] Add synthetic members to completions on dataclasses (#21446) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Typeshed has a (fake)
__getattr__method ontypes.ModuleTypewith a return type ofAny. We ignore this method when accessing attributes on module literals, but with this PR, we respect this method when dealing withModuleTypeitself. That is, we allow arbitrary attribute accesses on instances oftypes.ModuleType. This is useful because dynamic import mechanisms such asimportlib.import_moduleuseModuleTypeas a return type.closes astral-sh/ty#1346
Ecosystem
Massive reduction in diagnostics. The few new diagnostics are true positives.
Test Plan
Added regression test.