Implement some rules from flake8-logging-format

[edgarrmondragon]

#1850

[edgarrmondragon]

I don't think I'll implement G100 (extra whitelist) or G200 (exception instance used in log msg) for now, so this is ready for review :)

[charliermarsh]

One concern here is that PGH002 does the same thing:

resources/test/fixtures/flake8_logging_format/G010.py:3:1: PGH002 `warn` is deprecated in favor of `warning`

We could consider deprecating that rule, though, in favor of this more comprehensive plugin. We'd basically just redirect PGH002 to G010.

[edgarrmondragon]

I agree that it makes sense to prefer the logging plugin for this rule. Is it just a matter of adding it in src/rule_redirects.rs?

[charliermarsh]

Yeah, we'd need to delete all references to the rule (fixture files, etc.), then add the redirect to that map.

[charliermarsh]

In src/rules/tryceratops/rules/error_instead_of_exception.rs, I used some heuristics to detect whether the value is that of a logger (by matching on names, like logging, logger, self.logger, foo_logger, etc.). I'd like to be consistent between that rule and here. Any opinion on what's preferable?

[edgarrmondragon]

I followed the plugin here to just whitelist parser and warnings but it probably makes sense to make this more robust with some is_logger_candidate that incorporates your heuristic additionally. Happy to try out the refactor.

[charliermarsh]

That would be great, thanks!

[edgarrmondragon]

29b19c6