[ty] suppress autocomplete suggestions during variable binding #21549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusNygren
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
Statements such as `def foo(p<CURSOR>`, `def foo[T<CURSOR>` and `for foo<CURSOR>` should not generate any suggestions as these cases are introducing new names. If it's not possible to determine that suggestions should be omitted using token matching, we turn to traversing the AST to determine the context.
MichaReiser
requested review from
BurntSushi
and removed request for
AlexWaygood,
carljm,
dcreager and
sharkdp
RasmusNygren
force-pushed
the
suppress-suggestions-when-naming
branch
from
9ac8690 to
23fa8f5
Compare
AlexWaygood
added
server
AlexWaygood
changed the title
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
BurntSushi
approved these changes
Nov 21, 2025
Member
BurntSushi
left a comment
BurntSushi
left a comment
There was a problem hiding this comment.
Nice, this makes sense to me!
Member
|
Thank you!!! |
BurntSushi
added a commit
that referenced
this pull request
Nov 21, 2025
PR #21549 introduced a subtle overflow bug that seemed impossible, but can empirically happen. This PR fixes it by saturating to zero. I did try to write a regression test for this, but couldn't manage it. Instead, I'll attach before-and-after screen recordings.
BurntSushi
added a commit
that referenced
this pull request
Nov 21, 2025
PR #21549 introduced a subtle overflow bug that seemed impossible, but can empirically happen. This PR fixes it by saturating to zero. I did try to write a regression test for this, but couldn't manage it. Instead, I'll attach before-and-after screen recordings.
BurntSushi
added a commit
that referenced
this pull request
Nov 21, 2025
PR #21549 introduced a subtle overflow bug that seemed impossible, but can empirically happen. This PR fixes it by saturating to zero. I did try to write a regression test for this, but couldn't manage it. Instead, I'll attach before-and-after screen recordings.
dcreager
added a commit
that referenced
this pull request
Nov 24, 2025
…d-typevar * origin/main: (24 commits) [ty] Remove brittle constraint set reveal tests (#21568) [`ruff`] Catch more dummy variable uses (`RUF052`) (#19799) [ty] Use the same snapshot handling as other tests (#21564) [ty] suppress autocomplete suggestions during variable binding (#21549) Set severity for non-rule diagnostics (#21559) [ty] Add `with_type` convenience to display code (#21563) [ty] Implement docstring rendering to markdown (#21550) [ty] Reduce indentation of `TypeInferenceBuilder::infer_attribute_load` (#21560) Bump 0.14.6 (#21558) [ty] Improve debug messages when imports fail (#21555) [ty] Add support for relative import completions [ty] Refactor detection of import statements for completions [ty] Use dedicated collector for completions [ty] Attach subdiagnostics to `unresolved-import` errors for relative imports as well as absolute imports (#21554) [ty] support PEP 613 type aliases (#21394) [ty] More low-hanging fruit for inlay hint goto-definition (#21548) [ty] implement `TypedDict` structural assignment (#21467) [ty] Add more random TypeDetails and tests (#21546) [ty] Add goto for `Unknown` when it appears in an inlay hint (#21545) [ty] Add type definitions for `Type::SpecialForm`s (#21544) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statements such as
def foo(p<CURSOR>,def foo[T<CURSOR>andfor foo<CURSOR>should not generate any suggestions as these
cases are introducing new names.
If it's not possible to determine that suggestions should be omitted using token matching in an easy way, we turn
to traversing the AST to determine the context.
Summary
Fixes astral-sh/ty#1563
It keeps using the existing token matching pattern for the easy cases (nothing typed and most recent token is a definition token) and fallbacks to AST traveral for the slightly more difficult cases where token matching becomes difficult and error prone.
Test Plan
New test cases and sanity-checking in the ty playground