-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ty] make implicit submodule imports re-exported #21573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
|
Ecosystem looks great to me here -- the few added diagnostics just look like cases where we now have type information instead of |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unresolved-attribute |
0 | 470 | 11 |
unused-ignore-comment |
3 | 4 | 0 |
invalid-argument-type |
2 | 2 | 0 |
possibly-missing-attribute |
4 | 0 | 0 |
invalid-type-form |
0 | 3 | 0 |
invalid-assignment |
0 | 1 | 0 |
type-assertion-failure |
0 | 1 | 0 |
| Total | 9 | 481 | 11 |
|
oh THERE's the missing 400 fixes I thought one of my followups would hit! The one followup I forgot to try 😅 |
CodSpeed Performance ReportMerging #21573 will degrade performances by 4.98%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
WTF, is it a new rule that everything must regress performance on pydantic? This doesn't even seem to cause any new diagnostics on pydantic... |
|
I tried to explore this regression and I can't even reproduce it locally. Locally when I run |
Thus they work in
.pyifilesCloses astral-sh/ty#1609