flake8_executable: Only match shebang at beginning of line #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python implementation uses `re.match` for this, which only matches at the beginning of a line. https://github.com/xuhdev/flake8-executable/blob/v2.1.3/flake8_executable/__init__.py#L124 We could use `Regex::captures_read_at`, but that’s a more complicated API; it’s easier to anchor the regex with `^`. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
shebang-anchor
branch
from
25194a8 to
ce32035
Compare
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jan 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.235` -> `^0.0.236` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.236`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.236) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.235...v0.0.236) #### What's Changed ##### Rules - feat: implement `TRY002` and `TRY003` by [@​karpa4o4](https://togithub.com/karpa4o4) in [https://github.com/charliermarsh/ruff/pull/2135](https://togithub.com/charliermarsh/ruff/pull/2135) - Implementing `TRY400` by [@​Flowake](https://togithub.com/Flowake) in [https://github.com/charliermarsh/ruff/pull/2115](https://togithub.com/charliermarsh/ruff/pull/2115) - Implement some rules from `flake8-logging-format` (`G`) by [@​edgarrmondragon](https://togithub.com/edgarrmondragon) in [https://github.com/charliermarsh/ruff/pull/2150](https://togithub.com/charliermarsh/ruff/pull/2150) ##### Settings - Add strictness setting for `flake8-typing-imports` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2221](https://togithub.com/charliermarsh/ruff/pull/2221) - Implement `exempt-modules` setting from flake8-type-checking by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2230](https://togithub.com/charliermarsh/ruff/pull/2230) ##### Bug fixes - flake8\_executable: Only match shebang at beginning of line by [@​andersk](https://togithub.com/andersk) in [https://github.com/charliermarsh/ruff/pull/2183](https://togithub.com/charliermarsh/ruff/pull/2183) - Don't flag B009/B010 if identifiers would be mangled by [@​sciyoshi](https://togithub.com/sciyoshi) in [https://github.com/charliermarsh/ruff/pull/2204](https://togithub.com/charliermarsh/ruff/pull/2204) - fix: --explain reporting the wrong linter by [@​not-my-profile](https://togithub.com/not-my-profile) in [https://github.com/charliermarsh/ruff/pull/2215](https://togithub.com/charliermarsh/ruff/pull/2215) - Preserve indentation when fixing via LibCST by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2223](https://togithub.com/charliermarsh/ruff/pull/2223) - Avoid erroneous class autofixes in indented blocks by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2226](https://togithub.com/charliermarsh/ruff/pull/2226) - Fix range for `try-consider-else` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2228](https://togithub.com/charliermarsh/ruff/pull/2228) - Avoid flagging blind exceptions with valid logging by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2232](https://togithub.com/charliermarsh/ruff/pull/2232) - Avoid removing trailing comments on `pass` statements by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2235](https://togithub.com/charliermarsh/ruff/pull/2235) - Allow `pytest` in shebang by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2237](https://togithub.com/charliermarsh/ruff/pull/2237) - Wrap return-bool-condition-directly fixes in bool() by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2240](https://togithub.com/charliermarsh/ruff/pull/2240) #### New Contributors - [@​Flowake](https://togithub.com/Flowake) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2115](https://togithub.com/charliermarsh/ruff/pull/2115) - [@​henryiii](https://togithub.com/henryiii) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2200](https://togithub.com/charliermarsh/ruff/pull/2200) - [@​sciyoshi](https://togithub.com/sciyoshi) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2204](https://togithub.com/charliermarsh/ruff/pull/2204) **Full Changelog**: astral-sh/ruff@v0.0.235...v0.0.236 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExMS4xIn0=--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python implementation uses
re.matchfor this, which only matches at the beginning of a line.We could use
Regex::captures_read_at, but that’s a more complicated API; it’s easier to anchor the regex with^.(Cc @sbrugman)