Use BindingId copies in lieu of &BindingId in semantic model methods
#4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
May 24, 2023
| pub fn bindings(&self) -> std::collections::hash_map::Iter<&'a str, BindingId> { | ||
| self.bindings.iter() | ||
| pub fn bindings(&self) -> impl Iterator<Item = (&&str, BindingId)> + '_ { | ||
| self.bindings.iter().map(|(name, id)| (name, *id)) |
There was a problem hiding this comment.
This is a bit tedious. (Should this just be self.bindings.iter().copied()? That would change to &str.)
There was a problem hiding this comment.
I think so. &&str gets automatically dereferenced by Rust to &str but using copied() is just simpler :)
MichaReiser
approved these changes
May 24, 2023
| pub fn bindings(&self) -> std::collections::hash_map::Iter<&'a str, BindingId> { | ||
| self.bindings.iter() | ||
| pub fn bindings(&self) -> impl Iterator<Item = (&&str, BindingId)> + '_ { | ||
| self.bindings.iter().map(|(name, id)| (name, *id)) |
There was a problem hiding this comment.
I think so. &&str gets automatically dereferenced by Rust to &str but using copied() is just simpler :)
charliermarsh
force-pushed
the
charlie/copy
branch
from
fbbc716
to
524eda8
Compare
charliermarsh
force-pushed
the
charlie/copy
branch
from
524eda8
to
fc9235f
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partly putting this up because I don't have good intuition around these tradeoffs. Given that
BindingIdis small and implementsCopy, is it ever advantageous to pass around reference?