-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formatter: Remove CST and old formatting #4730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
MichaReiser
added
internal
An internal refactor or improvement
formatter
Related to the formatter
labels
May 30, 2023
MichaReiser
force-pushed
the
formatter-remove-cst
branch
from
May 30, 2023 16:29
c41a345
to
05d43e6
Compare
charliermarsh
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥲
Yeah I'm sorry. We'll bring back some of it. |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinux
Windows
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the formatter's CST implementation and the existing formatting code. I intend of reusing the formatter code by going back to this PR and copying the logic over.
The reason for deleting the code now is that updating to RustPython/Parser#76 causes some tests to panic and I don't believe it's still worth investing time into fixing the panics, considering that we intend replacing the code anyway.
I added some dummy formatting that simply prints the source code as is (it's not a 100% correct because RustPython's generated ranges do not include trailing trivia).
Why:
The new architecture avoids re-building the AST and collecting the children. This should result in a significantly faster formatter.
Test Plan
cargo test