Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StmtReturn #4960

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Implement StmtReturn #4960

merged 2 commits into from
Jun 8, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Jun 8, 2023

This implements StmtReturn as return or return {value}.

The snapshot diff is small because return occurs in functions (#4951).

konstin added 2 commits June 8, 2023 15:20
@konstin
Implement StmtPass
0766f5f 
This implements StmtPass as `pass`.

The snapshot diff is small because pass mainly occurs in bodies and function (#4951) and if/for bodies.
@konstin
Implement StmtReturn
0bd0ca7 
This implements StmtReturn as `return` or `return {value}`.

The snapshot diff is small because return occurs in functions (#4951)
@konstin konstin mentioned this pull request Jun 8, 2023
Merged
@konstin
Copy link
Member Author

konstin commented Jun 8, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@konstin konstin added the formatter Related to the formatter label Jun 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

PR Check Results

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.02      7.2±0.18ms     5.6 MB/sec    1.00      7.1±0.17ms     5.8 MB/sec
formatter/numpy/ctypeslib.py               1.02  1452.0±42.48µs    11.5 MB/sec    1.00  1418.8±45.69µs    11.7 MB/sec
formatter/numpy/globals.py                 1.03    166.3±6.75µs    17.7 MB/sec    1.00    161.5±6.55µs    18.3 MB/sec
formatter/pydantic/types.py                1.02      3.2±0.11ms     7.9 MB/sec    1.00      3.2±0.11ms     8.0 MB/sec
linter/all-rules/large/dataset.py          1.00     18.4±0.41ms     2.2 MB/sec    1.00     18.4±0.48ms     2.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.3±0.14ms     3.8 MB/sec    1.00      4.3±0.13ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.03   548.8±24.76µs     5.4 MB/sec    1.00   533.4±16.91µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.02      7.7±0.22ms     3.3 MB/sec    1.00      7.6±0.18ms     3.4 MB/sec
linter/default-rules/large/dataset.py      1.02      8.8±0.18ms     4.6 MB/sec    1.00      8.6±0.18ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1845.0±49.81µs     9.0 MB/sec    1.00  1845.0±53.46µs     9.0 MB/sec
linter/default-rules/numpy/globals.py      1.02   214.7±11.02µs    13.7 MB/sec    1.00    211.3±7.66µs    14.0 MB/sec
linter/default-rules/pydantic/types.py     1.02      3.9±0.11ms     6.5 MB/sec    1.00      3.9±0.09ms     6.6 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      6.9±0.03ms     5.9 MB/sec    1.01      6.9±0.04ms     5.9 MB/sec
formatter/numpy/ctypeslib.py               1.00   1327.1±7.44µs    12.5 MB/sec    1.01  1338.7±15.82µs    12.4 MB/sec
formatter/numpy/globals.py                 1.00    154.9±0.99µs    19.1 MB/sec    1.01    156.1±3.20µs    18.9 MB/sec
formatter/pydantic/types.py                1.00      3.1±0.03ms     8.4 MB/sec    1.00      3.1±0.04ms     8.4 MB/sec
linter/all-rules/large/dataset.py          1.00     16.6±0.07ms     2.4 MB/sec    1.00     16.6±0.08ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.3±0.02ms     3.9 MB/sec    1.00      4.3±0.02ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    429.2±4.55µs     6.9 MB/sec    1.00    428.0±4.84µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.1±0.03ms     3.6 MB/sec    1.00      7.1±0.05ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.4±0.03ms     4.9 MB/sec    1.00      8.4±0.06ms     4.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1746.0±11.22µs     9.5 MB/sec    1.01  1762.4±16.35µs     9.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    187.5±1.30µs    15.7 MB/sec    1.00    187.4±1.24µs    15.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.8±0.04ms     6.7 MB/sec    1.00      3.8±0.02ms     6.7 MB/sec

Base automatically changed from stmt-pass to main June 8, 2023 14:29
@konstin konstin merged commit 467df23 into main Jun 8, 2023
@konstin konstin deleted the stmt-return branch June 8, 2023 14:29
@konstin konstin mentioned this pull request Jun 12, 2023
Closed
72 tasks
konstin added a commit that referenced this pull request Jun 13, 2023
@konstin
Implement StmtReturn (#4960)
f317f00 
* Implement StmtPass

This implements StmtPass as `pass`.

The snapshot diff is small because pass mainly occurs in bodies and function (#4951) and if/for bodies.

* Implement StmtReturn

This implements StmtReturn as `return` or `return {value}`.

The snapshot diff is small because return occurs in functions (#4951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
formatter Related to the formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstin @MichaReiser