Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop having end-of-line comments expand parent #5353

Closed
wants to merge 2 commits into from
Closed

stop having end-of-line comments expand parent #5353

wants to merge 2 commits into from

Commits on Jun 25, 2023

  1. magic trailing comma for ExprList 

    seems mostly better, still need to think about

`json = {"k": {"k2": {"k3": [1,]}}}` where we differ from black in
trailing commans for all the outer dicts
    @davidszotten
    davidszotten committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    976b2d5 View commit details
    Browse the repository at this point in the history

  2. stop having end-of-line comments expand parent 

    this seems more in line with black (and seems to help with `StmtWith`
formatting)

only unexpected change in the diff afict is

```
while (
    some_condition(unformatted, args) # trailing some condition
    and anotherCondition or aThirdCondition  # trailing third condition
):  # comment
    print("Do something")
```

which for some reason (bug elsewhere?) now doesn't get wrapped
    @davidszotten
    davidszotten committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    5f25f86 View commit details
    Browse the repository at this point in the history