Something operator related that I don't understand yet

[MichaReiser]

Summary

Test Plan

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Extend formatter IR to support Black's expression formatting #5596
    • PR Prefer expanding parenthesized expressions before operands #5608
      • PR Remove mode from BestFitting #5609
        • PR Pass FormatContext to NeedsParentheses #5643
          • PR Introduce ExpressionRef #5644
        • PR Something operator related that I don't understand yet #5615 👈

This comment was auto-generated by Graphite.

[github-actions]

PR Check Results

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      7.9±0.03ms     5.1 MB/sec    1.00      8.0±0.02ms     5.1 MB/sec
formatter/numpy/ctypeslib.py               1.00   1762.2±4.01µs     9.4 MB/sec    1.01   1781.6±3.20µs     9.3 MB/sec
formatter/numpy/globals.py                 1.00    196.5±0.30µs    15.0 MB/sec    1.03    202.0±0.44µs    14.6 MB/sec
formatter/pydantic/types.py                1.00      3.9±0.03ms     6.5 MB/sec    1.00      3.9±0.01ms     6.5 MB/sec
linter/all-rules/large/dataset.py          1.01     13.5±0.15ms     3.0 MB/sec    1.00     13.4±0.07ms     3.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.01ms     4.9 MB/sec    1.00      3.4±0.01ms     4.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    428.4±0.95µs     6.9 MB/sec    1.00    430.2±0.42µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.9±0.03ms     4.3 MB/sec    1.00      5.9±0.02ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.00      6.7±0.03ms     6.1 MB/sec    1.01      6.7±0.04ms     6.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1462.0±3.34µs    11.4 MB/sec    1.01   1471.3±2.89µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    166.5±1.83µs    17.7 MB/sec    1.01    167.4±0.30µs    17.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.01ms     8.5 MB/sec    1.01      3.0±0.01ms     8.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      9.6±0.16ms     4.2 MB/sec    1.01      9.6±0.16ms     4.2 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.1±0.05ms     8.0 MB/sec    1.02      2.1±0.05ms     7.9 MB/sec
formatter/numpy/globals.py                 1.00    232.1±5.21µs    12.7 MB/sec    1.04   241.6±10.09µs    12.2 MB/sec
formatter/pydantic/types.py                1.00      4.6±0.09ms     5.6 MB/sec    1.03      4.7±0.16ms     5.4 MB/sec
linter/all-rules/large/dataset.py          1.00     16.3±0.28ms     2.5 MB/sec    1.00     16.3±0.28ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.2±0.08ms     4.0 MB/sec    1.00      4.2±0.07ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00   513.5±15.08µs     5.7 MB/sec    1.01   517.7±17.80µs     5.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.2±0.12ms     3.5 MB/sec    1.02      7.4±0.18ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.00      8.2±0.14ms     5.0 MB/sec    1.00      8.2±0.13ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1763.4±43.76µs     9.4 MB/sec    1.00  1754.6±30.56µs     9.5 MB/sec
linter/default-rules/numpy/globals.py      1.00    206.4±5.34µs    14.3 MB/sec    1.00    207.0±5.89µs    14.3 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.7±0.10ms     6.9 MB/sec    1.00      3.7±0.05ms     6.9 MB/sec

[charliermarsh]

Great PR title regardless.

[MichaReiser]

Great PR title regardless.

Lol, I needed to push my changes because I wanted to work on it on my notebook. Unfortunately, Graphite only allows you to do push the changes by creating PRs (at least to my knowledge).

[MichaReiser]

It turns out, I did not understand it at all. This won't be necessary ;)