Format DictComp expression
#5771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnpryer
commented
Jul 15, 2023
Comment on lines
+339
to
+342
| + for ( | ||
| + k, | ||
| + v, | ||
| + ) in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension |
There was a problem hiding this comment.
Note the generators formatting.
There was a problem hiding this comment.
You mean the parentheses around the tuple and that it expands over multiple lines? We probably need to use the StripInsideForLoop layout here as well (unrelated to your PR)
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
MichaReiser
approved these changes
Jul 15, 2023
Comment on lines
+339
to
+342
| + for ( | ||
| + k, | ||
| + v, | ||
| + ) in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension |
There was a problem hiding this comment.
You mean the parentheses around the tuple and that it expands over multiple lines? We probably need to use the StripInsideForLoop layout here as well (unrelated to your PR)
evanrittenhouse
pushed a commit
to evanrittenhouse/ruff
that referenced
this pull request
Jul 19, 2023
## Summary Format `DictComp` like `ListComp` from astral-sh#5600. It's not 100%, but I figured maybe it's worth starting to explore. ## Test Plan Added ruff fixture based on `ListComp`'s.
konstin
pushed a commit
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Format
DictComplikeListCompfrom #5600. It's not 100%, but I figured maybe it's worth starting to explore.Test Plan
Added ruff fixture based on
ListComp's.