Allow `flake8-type-checking` rules to automatically quote runtime-evaluated references #6001

charliermarsh · 2023-07-23T02:03:38Z

Summary

This allows us to fix usages like:

from pandas import DataFrame

def baz() -> DataFrame:
    ...

By quoting the DataFrame in -> DataFrame. Without quotes, moving from pandas import DataFrame into an if TYPE_CHECKING: block will fail at runtime, since Python tries to evaluate the annotation to add it to the function's __annotations__.

Unfortunately, this does require us to split our "annotation kind" flags into three categories, rather than two:

typing-only: The annotation is only evaluated at type-checking-time.
runtime-evaluated: Python will evaluate the annotation at runtime (like above) -- but we're willing to quote it.
runtime-required: Python will evaluate the annotation at runtime (like above), and some library (like Pydantic) needs it to be available at runtime, so we can't quote it.

This functionality is gated behind a setting (flake8-type-checking.quote-annotations).

Closes #5559.

github-actions · 2023-07-23T02:52:04Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

charliermarsh · 2023-07-23T04:41:33Z

This "works" on Dagster in that it generates 1834 fixes (and no syntax errors) that generally look right:

--- a/examples/assets_smoke_test/assets_smoke_test/pure_python_assets.py
+++ b/examples/assets_smoke_test/assets_smoke_test/pure_python_assets.py
@@ -1,5 +1,9 @@
+from typing import TYPE_CHECKING
+
 from dagster import SourceAsset, TableSchema, asset
-from pandas import DataFrame
+
+if TYPE_CHECKING:
+    from pandas import DataFrame

 raw_country_populations = SourceAsset(
     "raw_country_populations",
@@ -19,7 +23,7 @@


 @asset
-def country_populations(raw_country_populations) -> DataFrame:
+def country_populations(raw_country_populations) -> "DataFrame":
     country_populations = raw_country_populations.copy()
     country_populations["change"] = (
         country_populations["change"]
@@ -32,13 +36,13 @@ def country_populations(raw_country_populations) -> DataFrame:


 @asset
-def continent_stats(country_populations: DataFrame) -> DataFrame:
+def continent_stats(country_populations: "DataFrame") -> "DataFrame":
     result = country_populations.groupby("continent").agg({"pop2019": "sum", "change": "mean"})
     return result


 @asset
-def country_stats(country_populations: DataFrame, continent_stats: DataFrame) -> DataFrame:
+def country_stats(country_populations: "DataFrame", continent_stats: "DataFrame") -> "DataFrame":
     result = country_populations.join(continent_stats, on="continent", lsuffix="_continent")
     result["continent_pop_fraction"] = result["pop2019"] / result["pop2019_continent"]
     return result

tylerlaprade · 2023-07-23T15:59:47Z

Yes! I was wondering yesterday if I misunderstood the purpose of the rule, because it was barely applying. When I realized I needed to add quotes, I briefly started manually adding them, but then realized it was unfeasible to do manually on even a medium-sized codebase.

charliermarsh · 2023-07-23T16:00:55Z

(If you use from __future__ import annotations, you'll also get more of the expected changes, but that's not always feasible to add either depending on your use-case.)

charliermarsh · 2023-08-20T23:09:16Z

This was blocked as it became too difficult to quote an annotation given just the reference range. It should be unblocked now that we store all expressions in a vector, since we can store an ExpressionId on all references to go from reference to Expr.

github-actions · 2023-12-10T03:20:14Z

`ruff-ecosystem` results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+2 -1 violations, +0 -0 fixes in 41 projects)

ibis-project/ibis (+2 -0 violations, +0 -0 fixes)

+ ibis/common/tests/test_graph_benchmarks.py:6:37: RUF100 Unused `noqa` directive (unused: `TCH002`)
+ ibis/common/typing.py:33:46: RUF100 Unused `noqa` directive (unused: `TCH002`)

zulip/zulip (+0 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-preview --select ALL

- analytics/views/stats.py:13:31: TCH002 Move third-party import `typing_extensions.TypeAlias` into a type-checking block

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
RUF100	2	2	0	0	0
TCH002	1	0	1	0	0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+2 -1 violations, +0 -0 fixes in 41 projects)

ibis-project/ibis (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ ibis/common/tests/test_graph_benchmarks.py:6:37: RUF100 Unused `noqa` directive (unused: `TCH002`)
+ ibis/common/typing.py:33:46: RUF100 Unused `noqa` directive (unused: `TCH002`)

zulip/zulip (+0 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

- analytics/views/stats.py:13:31: TCH002 Move third-party import `typing_extensions.TypeAlias` into a type-checking block

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
RUF100	2	2	0	0	0
TCH002	1	0	1	0	0

charliermarsh · 2023-12-10T03:35:14Z

The diff of this on Dagster actually looks really good.

charliermarsh · 2023-12-10T03:36:49Z

For example:

@@ -25,7 +25,6 @@
 from dagster._core.events import DagsterEvent
 from dagster._core.execution.api import create_execution_plan, scoped_job_context
 from dagster._core.execution.plan.outputs import StepOutputHandle
-from dagster._core.execution.plan.plan import ExecutionPlan
 from dagster._core.execution.plan.state import KnownExecutionState
 from dagster._core.execution.plan.step import ExecutionStep
 from dagster._core.execution.resources_init import (
@@ -34,7 +33,6 @@
 )
 from dagster._core.instance import DagsterInstance
 from dagster._core.instance.ref import InstanceRef
-from dagster._core.log_manager import DagsterLogManager
 from dagster._core.storage.dagster_run import DagsterRun, DagsterRunStatus
 from dagster._core.system_config.objects import ResolvedRunConfig, ResourceConfig
 from dagster._core.utils import make_new_run_id
@@ -47,6 +45,8 @@
 from .serialize import PICKLE_PROTOCOL

 if TYPE_CHECKING:
+    from dagster._core.execution.plan.plan import ExecutionPlan
+    from dagster._core.log_manager import DagsterLogManager
     from dagster._core.definitions.node_definition import NodeDefinition


@@ -81,8 +81,8 @@ def _setup_resources(
         self,
         resource_defs: Mapping[str, ResourceDefinition],
         resource_configs: Mapping[str, ResourceConfig],
-        log_manager: DagsterLogManager,
-        execution_plan: Optional[ExecutionPlan],
+        log_manager: "DagsterLogManager",
+        execution_plan: Optional["ExecutionPlan"],
         dagster_run: Optional[DagsterRun],
         resource_keys_to_init: Optional[AbstractSet[str]],
         instance: Optional[DagsterInstance],

charliermarsh · 2023-12-10T03:38:23Z

We may want to add a setting to allow users to either (1) insert __future__ or (2) quote annotations or (3) do neither.

charliermarsh · 2023-12-10T03:39:21Z

@smackesey -- You may be interested in this (finally resurrected after a long break).

dhruvmanila · 2023-12-11T19:13:19Z

I've gone through the changes and it looks good although I'd like to give a second look at it in the evening.

smackesey · 2023-12-11T20:11:37Z

You may be interested in this

Definitely-- thanks for bringing it back! To spare churn in imports for other engs I like to apply changes in one PR-- is this anywhere on your agenda: #1107? Would be great to apply them both at once.

charliermarsh · 2023-12-12T00:45:03Z

@smackesey - I'm still interested in supporting that but it won't be merged on the same timeline, since it requires us to build up an import map that we share across modules.

MichaReiser

Looks good to me, but I only reviewed if I roughly understand what's happening, not if the implemented semantics are correct (because I don't understand thme).

crates/ruff_linter/src/checkers/ast/mod.rs

...es/ruff_linter/src/rules/flake8_type_checking/rules/runtime_import_in_type_checking_block.rs

crates/ruff_linter/src/rules/flake8_type_checking/helpers.rs

MichaReiser · 2023-12-12T02:20:59Z

crates/ruff_linter/src/rules/flake8_type_checking/imports.rs

+    /// The trimmed range of the import (e.g., `List` in `from typing import List`).
+    pub(crate) range: TextRange,
+    /// The range of the import's parent statement.
+    pub(crate) parent_range: Option<TextRange>,


In which situations can the parent_range be None? Shouldn't an import always come from a statement. This might be worth documenting.

crates/ruff_python_semantic/src/model.rs

crates/ruff_python_semantic/src/reference.rs

MichaReiser · 2023-12-12T02:28:38Z

crates/ruff_workspace/src/options.rs

+    /// In other words, moving `from collections.abc import Sequence` into an
+    /// `if TYPE_CHECKING:` block above would cause a runtime error.


This part confused me. I admint, mainly because I didn't read carefully but I first thought that what ruff does will create a runtime error.

maybe explain why it causes a runtime error.

Or it might be that I got confused because the documentation explains what it does and the example shows when it doesn't work (rather than when it does).

would cause a runtime error because the type is no longer available at runtime.

dhruvmanila

Thanks! This is a great improvement to the rule. Overall the implementation looks really solid apart from some minor nits.

crates/ruff_linter/src/checkers/ast/mod.rs

dhruvmanila · 2023-12-13T01:11:19Z

crates/ruff_linter/src/checkers/ast/mod.rs

-                            flake8_type_checking::helpers::runtime_evaluated_class(
+                            flake8_type_checking::helpers::runtime_required_class(


It's unfortunate that we now have runtime required internally but runtime evaluated in the user facing option. Maybe we could use either v0.2.0 or v0.3.0 as a way to rename these options.

Yes great observation! It's really unfortunate.

Actually, I'm gonna change the internal names.

crates/ruff_linter/src/rules/flake8_type_checking/helpers.rs

dhruvmanila · 2023-12-13T01:39:19Z

crates/ruff_linter/src/rules/flake8_type_checking/helpers.rs

+    if annotation.contains('\'') || annotation.contains('"') {
+        return Err(anyhow::anyhow!("Annotation already contains a quote"));
+    }


In the function example, we've mentioned to update the internal quote:

When quoting Series in Series[Literal["pd.Timestamp"]], we want "Series[Literal['pd.Timestamp']]".

With this code, I think that doesn't work, right? Can we use the Stylist to only check for the opposite quote?

Yeah sorry, it doesn't do that yet.

...es/ruff_linter/src/rules/flake8_type_checking/rules/runtime_import_in_type_checking_block.rs

charliermarsh force-pushed the charlie/quote branch from 270814f to b760b41 Compare July 23, 2023 02:07

charliermarsh force-pushed the charlie/quote branch 5 times, most recently from 41a82c7 to 33ee9b7 Compare July 23, 2023 04:34

charliermarsh mentioned this pull request Jul 23, 2023

TCH setting to autofix with conversion to string #5559

Closed

charliermarsh force-pushed the charlie/quote branch 2 times, most recently from 1976038 to 0c338cf Compare July 26, 2023 18:24

charliermarsh force-pushed the charlie/quote branch from 0c338cf to a457f8b Compare August 20, 2023 23:37

charliermarsh mentioned this pull request Sep 7, 2023

TCH004: false positive for import that is used only in type hints #7214

Closed

charliermarsh force-pushed the charlie/quote branch from a457f8b to ee16edc Compare October 10, 2023 16:20

charliermarsh force-pushed the charlie/quote branch from ee16edc to 6c4fd6b Compare December 10, 2023 03:07

charliermarsh force-pushed the charlie/quote branch 2 times, most recently from 57915b4 to 77301d4 Compare December 10, 2023 03:31

charliermarsh marked this pull request as ready for review December 10, 2023 03:37

charliermarsh force-pushed the charlie/quote branch 2 times, most recently from 4ebec4e to b19e86e Compare December 11, 2023 16:16

charliermarsh temporarily deployed to release December 11, 2023 16:16 — with GitHub Actions Inactive

charliermarsh had a problem deploying to release December 11, 2023 16:40 — with GitHub Actions Error

charliermarsh force-pushed the charlie/quote branch from 653b685 to ce3d2b2 Compare December 11, 2023 16:45

charliermarsh had a problem deploying to release December 11, 2023 16:45 — with GitHub Actions Error

charliermarsh force-pushed the charlie/quote branch from ce3d2b2 to c6f9ab4 Compare December 11, 2023 16:46

charliermarsh had a problem deploying to release December 11, 2023 16:46 — with GitHub Actions Error

charliermarsh force-pushed the charlie/quote branch from c6f9ab4 to eef1966 Compare December 11, 2023 16:47

charliermarsh had a problem deploying to release December 11, 2023 16:48 — with GitHub Actions Error

charliermarsh force-pushed the charlie/quote branch from eef1966 to faf1c2f Compare December 11, 2023 16:52

charliermarsh requested review from zanieb and dhruvmanila December 11, 2023 16:52

charliermarsh temporarily deployed to release December 11, 2023 16:52 — with GitHub Actions Inactive

charliermarsh force-pushed the charlie/quote branch from faf1c2f to bf5749a Compare December 11, 2023 17:08

MichaReiser reviewed Dec 12, 2023

View reviewed changes

dhruvmanila approved these changes Dec 13, 2023

View reviewed changes

charliermarsh added 4 commits December 12, 2023 20:57

Add quote support

9b3ac0a

Add setting

176d325

Properly support runtime annotations

81966e0

Use boolean

4a38344

charliermarsh force-pushed the charlie/quote branch from bf5749a to 054dd68 Compare December 13, 2023 02:46

Review feedback

5027f0d

charliermarsh force-pushed the charlie/quote branch 3 times, most recently from daa49ed to f3eaec7 Compare December 13, 2023 03:07

charliermarsh enabled auto-merge (squash) December 13, 2023 03:07

Merge branch 'main' into charlie/quote

f3eaec7

charliermarsh merged commit 1a65e54 into main Dec 13, 2023
16 checks passed

charliermarsh deleted the charlie/quote branch December 13, 2023 03:12

krehel mentioned this pull request Dec 13, 2023

ruff 0.1.8 Homebrew/homebrew-core#157266

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `flake8-type-checking` rules to automatically quote runtime-evaluated references #6001

Allow `flake8-type-checking` rules to automatically quote runtime-evaluated references #6001

charliermarsh commented Jul 23, 2023 •

edited

Loading

github-actions bot commented Jul 23, 2023 •

edited

Loading

charliermarsh commented Jul 23, 2023 •

edited

Loading

tylerlaprade commented Jul 23, 2023

charliermarsh commented Jul 23, 2023

charliermarsh commented Aug 20, 2023

github-actions bot commented Dec 10, 2023 •

edited

Loading

charliermarsh commented Dec 10, 2023

charliermarsh commented Dec 10, 2023

charliermarsh commented Dec 10, 2023

charliermarsh commented Dec 10, 2023

dhruvmanila commented Dec 11, 2023

smackesey commented Dec 11, 2023

charliermarsh commented Dec 12, 2023

MichaReiser left a comment

MichaReiser Dec 12, 2023

MichaReiser Dec 12, 2023

dhruvmanila left a comment

dhruvmanila Dec 13, 2023

charliermarsh Dec 13, 2023

charliermarsh Dec 13, 2023

dhruvmanila Dec 13, 2023

charliermarsh Dec 13, 2023

		/// In other words, moving `from collections.abc import Sequence` into an
		/// `if TYPE_CHECKING:` block above would cause a runtime error.

		flake8_type_checking::helpers::runtime_evaluated_class(
		flake8_type_checking::helpers::runtime_required_class(

Allow flake8-type-checking rules to automatically quote runtime-evaluated references #6001

Allow flake8-type-checking rules to automatically quote runtime-evaluated references #6001

Conversation

charliermarsh commented Jul 23, 2023 • edited Loading

Summary

github-actions bot commented Jul 23, 2023 • edited Loading

PR Check Results

Ecosystem

charliermarsh commented Jul 23, 2023 • edited Loading

tylerlaprade commented Jul 23, 2023

charliermarsh commented Jul 23, 2023

charliermarsh commented Aug 20, 2023

github-actions bot commented Dec 10, 2023 • edited Loading

ruff-ecosystem results

Linter (stable)

Linter (preview)

charliermarsh commented Dec 10, 2023

charliermarsh commented Dec 10, 2023

charliermarsh commented Dec 10, 2023

charliermarsh commented Dec 10, 2023

dhruvmanila commented Dec 11, 2023

smackesey commented Dec 11, 2023

charliermarsh commented Dec 12, 2023

MichaReiser left a comment

Choose a reason for hiding this comment

MichaReiser Dec 12, 2023

Choose a reason for hiding this comment

MichaReiser Dec 12, 2023

Choose a reason for hiding this comment

dhruvmanila left a comment

Choose a reason for hiding this comment

dhruvmanila Dec 13, 2023

Choose a reason for hiding this comment

charliermarsh Dec 13, 2023

Choose a reason for hiding this comment

charliermarsh Dec 13, 2023

Choose a reason for hiding this comment

dhruvmanila Dec 13, 2023

Choose a reason for hiding this comment

charliermarsh Dec 13, 2023

Choose a reason for hiding this comment

Allow `flake8-type-checking` rules to automatically quote runtime-evaluated references #6001

Allow `flake8-type-checking` rules to automatically quote runtime-evaluated references #6001

charliermarsh commented Jul 23, 2023 •

edited

Loading

github-actions bot commented Jul 23, 2023 •

edited

Loading

charliermarsh commented Jul 23, 2023 •

edited

Loading

github-actions bot commented Dec 10, 2023 •

edited

Loading

`ruff-ecosystem` results