Avoid JSON parse error on playground load #6519

charliermarsh · 2023-08-12T04:02:20Z

Summary

On page load, the playground very briefly flickers a JSON parse error. Due to our use of useDeferredValue, we attempt to parse the empty JSON string settings, since after const initialized = ruffVersion != null; returns true, we get one render with the stale deferred value.

This PR refactors the state, such that we start by storing null for the Source, and use the Source itself to determine initialization status.

Test Plan

Set a breakpoint in the catch path in Editor; verified that it no longer triggers on load (but did on main).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.284` -> `==0.0.285` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.285?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.285?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.284/0.0.285?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.284/0.0.285?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.285`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.285) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.284...v0.0.285) #### What's Changed ##### New rules - \[`flake8-pytest-style`] Implement `pytest-unittest-raises-assertion` (`PT027`) by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6554 - \[`flake8-pytest-style`] Implement `pytest-duplicate-parametrize-test-cases` (`PT014`) by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6598 - \[`flake8-tidy-imports`] Implement `banned-module-level-imports` (`TID253`) by [@durumu](https://togithub.com/durumu) in [astral-sh/ruff#6378 - \[`pylint`] Implement `bad-dunder-name` (`W3201`) (in the Ruff nursery) by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6486 - \[`pylint`] Implement `subprocess-run-check` (`W1510`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#6487 - \[`ruff`] Implement `quadratic-list-summation` (`RUF017`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#6489 ##### Rule changes - \[`flake8-bugbear`] Add autofix for `B006` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#6131 - \[`flake8-pyi`] Avoid applying `PYI055` to runtime-evaluated annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6457 - \[`flake8-self`] Allow `os._exit` accesses in `SLF001` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6490 - \[`perflint`] Ignore `PERF203` if `try` contains loop control flow statements by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#6536 - \[`pylint`] Check for invalid format type specifiers in nested replacements for `PLE1300` by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6616 - \[`tryceratops`] Omit `NotImplementedError` from `TRY003` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6568 ##### Settings - Respect `.ipynb` and `.pyi` sources when linting from stdin by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6628 - Support glob patterns for `raises_require_match_for` and `raises_require_match_for` by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6635 ##### Bug Fixes - Make `lambda-assignment` fix always-manual in class bodies by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6626 - Fix counting of message arguments when msg is provided as a keyword by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6456 - Add container types to `E721` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6469 - Respect scoping rules when identifying builtins by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6468 - Respect tab width in line-length heuristic by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6491 - Respect dummy-variable-rgx for unused bound exceptions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6492 - Fix detection of top-level imports with newlines in `E402` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6526 - Allow if-expression with dual string arms in `invalid-envvar-value` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6538 - Add deprecated unittest assertions to PT009 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6572 - Avoid unused argument rules when functions call `locals()` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6578 - Allow top-level `await` in Jupyter notebooks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6607 - Don't detect `pandas#values` for stores, deletes, or class accesses by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6631 - Avoid removing parentheses in `E712` fix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6575 - Skip whitespace between comments at start of file e.g. for `I002` by [@durumu](https://togithub.com/durumu) in [astral-sh/ruff#6523 - Add support for nested replacements inside format specifications e.g. for `PLE1300` by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6616 ##### Playground - Shared playground links now use short URLs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6383 - Fix possible JSON parse error on playground load by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6519 - Fix unreachable panic in playground by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#6623 ##### Performance - Improve tokenizer performance for ASCII only identifiers by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#6609 #### New Contributors - [@magic-akari](https://togithub.com/magic-akari) made their first contribution in [astral-sh/ruff#6472 - [@durumu](https://togithub.com/durumu) made their first contribution in [astral-sh/ruff#6378 - [@jamesbraza](https://togithub.com/jamesbraza) made their first contribution in [astral-sh/ruff#6520 - [@takumaw](https://togithub.com/takumaw) made their first contribution in [astral-sh/ruff#6533 - [@noklam](https://togithub.com/noklam) made their first contribution in [astral-sh/ruff#6573 - [@Teraskull](https://togithub.com/Teraskull) made their first contribution in [astral-sh/ruff#6605 **Full Changelog**: astral-sh/ruff@v0.0.284...v0.0.285 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.284` -> `==0.0.285` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.285?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.285?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.284/0.0.285?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.284/0.0.285?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.285`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.285) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.284...v0.0.285) #### What's Changed ##### New rules - \[`flake8-pytest-style`] Implement `pytest-unittest-raises-assertion` (`PT027`) by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6554 - \[`flake8-pytest-style`] Implement `pytest-duplicate-parametrize-test-cases` (`PT014`) by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6598 - \[`flake8-tidy-imports`] Implement `banned-module-level-imports` (`TID253`) by [@durumu](https://togithub.com/durumu) in [astral-sh/ruff#6378 - \[`pylint`] Implement `bad-dunder-name` (`W3201`) (in the Ruff nursery) by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6486 - \[`pylint`] Implement `subprocess-run-check` (`W1510`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#6487 - \[`ruff`] Implement `quadratic-list-summation` (`RUF017`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#6489 ##### Rule changes - \[`flake8-bugbear`] Add autofix for `B006` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#6131 - \[`flake8-pyi`] Avoid applying `PYI055` to runtime-evaluated annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6457 - \[`flake8-self`] Allow `os._exit` accesses in `SLF001` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6490 - \[`perflint`] Ignore `PERF203` if `try` contains loop control flow statements by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#6536 - \[`pylint`] Check for invalid format type specifiers in nested replacements for `PLE1300` by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6616 - \[`tryceratops`] Omit `NotImplementedError` from `TRY003` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6568 ##### Settings - Respect `.ipynb` and `.pyi` sources when linting from stdin by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6628 - Support glob patterns for `raises_require_match_for` and `raises_require_match_for` by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6635 ##### Bug Fixes - Make `lambda-assignment` fix always-manual in class bodies by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6626 - Fix counting of message arguments when msg is provided as a keyword by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6456 - Add container types to `E721` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6469 - Respect scoping rules when identifying builtins by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6468 - Respect tab width in line-length heuristic by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6491 - Respect dummy-variable-rgx for unused bound exceptions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6492 - Fix detection of top-level imports with newlines in `E402` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6526 - Allow if-expression with dual string arms in `invalid-envvar-value` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6538 - Add deprecated unittest assertions to PT009 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6572 - Avoid unused argument rules when functions call `locals()` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6578 - Allow top-level `await` in Jupyter notebooks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6607 - Don't detect `pandas#values` for stores, deletes, or class accesses by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6631 - Avoid removing parentheses in `E712` fix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6575 - Skip whitespace between comments at start of file e.g. for `I002` by [@durumu](https://togithub.com/durumu) in [astral-sh/ruff#6523 - Add support for nested replacements inside format specifications e.g. for `PLE1300` by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6616 ##### Playground - Shared playground links now use short URLs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6383 - Fix possible JSON parse error on playground load by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6519 - Fix unreachable panic in playground by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#6623 ##### Performance - Improve tokenizer performance for ASCII only identifiers by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#6609 #### New Contributors - [@magic-akari](https://togithub.com/magic-akari) made their first contribution in [astral-sh/ruff#6472 - [@durumu](https://togithub.com/durumu) made their first contribution in [astral-sh/ruff#6378 - [@jamesbraza](https://togithub.com/jamesbraza) made their first contribution in [astral-sh/ruff#6520 - [@takumaw](https://togithub.com/takumaw) made their first contribution in [astral-sh/ruff#6533 - [@noklam](https://togithub.com/noklam) made their first contribution in [astral-sh/ruff#6573 - [@Teraskull](https://togithub.com/Teraskull) made their first contribution in [astral-sh/ruff#6605 **Full Changelog**: astral-sh/ruff@v0.0.284...v0.0.285 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

charliermarsh added the playground A playground-specific issue label Aug 12, 2023

Avoid JSON parse error on playground load

de5c4f4

charliermarsh force-pushed the charlie/error branch from 3c1132c to de5c4f4 Compare August 12, 2023 04:02

charliermarsh enabled auto-merge (squash) August 12, 2023 04:04

charliermarsh merged commit a1da9da into main Aug 12, 2023
14 checks passed

charliermarsh deleted the charlie/error branch August 12, 2023 04:11

chenrui333 mentioned this pull request Aug 17, 2023

ruff 0.0.285 Homebrew/homebrew-core#139823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid JSON parse error on playground load #6519

Avoid JSON parse error on playground load #6519

charliermarsh commented Aug 12, 2023

Avoid JSON parse error on playground load #6519

Avoid JSON parse error on playground load #6519

Conversation

charliermarsh commented Aug 12, 2023

Summary

Test Plan