Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parenthesizing of implicit strings #6852

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

MichaReiser
Copy link
Member

Summary

Closes #5893

Test Plan

Added tests

Verified that similarity index remains unchanged

@MichaReiser
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser force-pushed the fix-instable-string-concat-formatting branch from 4f00c24 to 36c6eed Compare August 24, 2023 12:20
@MichaReiser MichaReiser added the formatter Related to the formatter label Aug 24, 2023
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that's the majority of the instabilities i think

@MichaReiser MichaReiser enabled auto-merge (squash) August 24, 2023 12:23
@MichaReiser MichaReiser merged commit 8b46b71 into main Aug 24, 2023
16 checks passed
@MichaReiser MichaReiser deleted the fix-instable-string-concat-formatting branch August 24, 2023 12:31
@github-actions
Copy link
Contributor

PR Check Results

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      5.1±0.15ms     8.0 MB/sec    1.00      5.1±0.17ms     8.0 MB/sec
formatter/numpy/ctypeslib.py               1.00  1065.5±54.95µs    15.6 MB/sec    1.00  1062.1±37.93µs    15.7 MB/sec
formatter/numpy/globals.py                 1.00     97.3±6.48µs    30.3 MB/sec    1.00     97.1±5.89µs    30.4 MB/sec
formatter/pydantic/types.py                1.00      2.1±0.09ms    12.2 MB/sec    1.00      2.1±0.07ms    12.3 MB/sec
linter/all-rules/large/dataset.py          1.03     14.4±0.25ms     2.8 MB/sec    1.00     14.0±0.25ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.7±0.08ms     4.5 MB/sec    1.00      3.7±0.13ms     4.5 MB/sec
linter/all-rules/numpy/globals.py          1.00   522.6±19.28µs     5.6 MB/sec    1.00   525.0±19.53µs     5.6 MB/sec
linter/all-rules/pydantic/types.py         1.01      7.3±0.20ms     3.5 MB/sec    1.00      7.3±0.28ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.01      7.4±0.14ms     5.5 MB/sec    1.00      7.3±0.12ms     5.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1582.5±48.81µs    10.5 MB/sec    1.01  1592.3±34.69µs    10.5 MB/sec
linter/default-rules/numpy/globals.py      1.00    192.4±8.06µs    15.3 MB/sec    1.00   193.3±11.61µs    15.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.3±0.09ms     7.8 MB/sec    1.01      3.3±0.06ms     7.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      5.6±0.14ms     7.2 MB/sec    1.00      5.6±0.14ms     7.2 MB/sec
formatter/numpy/ctypeslib.py               1.00  1155.9±27.95µs    14.4 MB/sec    1.00  1158.2±24.61µs    14.4 MB/sec
formatter/numpy/globals.py                 1.00    109.5±2.18µs    27.0 MB/sec    1.02    111.6±4.26µs    26.4 MB/sec
formatter/pydantic/types.py                1.00      2.3±0.06ms    11.0 MB/sec    1.01      2.3±0.06ms    10.9 MB/sec
linter/all-rules/large/dataset.py          1.01     15.3±0.24ms     2.7 MB/sec    1.00     15.1±0.21ms     2.7 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.2±0.10ms     4.0 MB/sec    1.00      4.1±0.07ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.01   520.5±15.39µs     5.7 MB/sec    1.00   517.2±10.51µs     5.7 MB/sec
linter/all-rules/pydantic/types.py         1.01      7.9±0.14ms     3.2 MB/sec    1.00      7.8±0.13ms     3.3 MB/sec
linter/default-rules/large/dataset.py      1.01      8.4±0.14ms     4.8 MB/sec    1.00      8.4±0.10ms     4.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02  1824.8±39.78µs     9.1 MB/sec    1.00  1790.4±25.43µs     9.3 MB/sec
linter/default-rules/numpy/globals.py      1.02    212.1±8.04µs    13.9 MB/sec    1.00    208.6±5.04µs    14.1 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.8±0.09ms     6.7 MB/sec    1.00      3.8±0.06ms     6.8 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable formatting of parenthesized implicit string concatenation
2 participants