Truncate ecosystem comment when necessary #6899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
MichaReiser
force-pushed
the
ecosystem-truncate-comment
branch
from
9f7b89f
to
5ef1812
Compare
CodSpeed Performance ReportMerging #6899 will not alter performanceComparing Summary
|
MichaReiser
force-pushed
the
ecosystem-truncate-comment
branch
11 times, most recently
from
9580b93
to
911ced8
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
MichaReiser
force-pushed
the
ecosystem-truncate-comment
branch
from
911ced8
to
6df5950
Compare
MichaReiser
force-pushed
the
ecosystem-truncate-comment
branch
from
6df5950
to
a22072c
Compare
MichaReiser
commented
Aug 27, 2023
| comment_tag: PR Check Results | ||
| comment-d: ${{ steps.find-comment.outputs.comment-id }} | ||
| issue-number: ${{ steps.pr-number.outputs.pr-number }} | ||
| body-path: comment.txt |
There was a problem hiding this comment.
It needs to be a file to avoid OOMing when loading the content
MichaReiser
force-pushed
the
ecosystem-truncate-comment
branch
from
a22072c
to
4f8ddd1
Compare
charliermarsh
approved these changes
Aug 27, 2023
Sure 😆 |
MichaReiser
force-pushed
the
ecosystem-truncate-comment
branch
from
4f8ddd1
to
3be8b83
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
1 similar comment
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
MichaReiser
force-pushed
the
ecosystem-truncate-comment
branch
from
5ade181
to
cf3ea14
Compare
MichaReiser
force-pushed
the
ecosystem-truncate-comment
branch
from
cf3ea14
to
3f3e8da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that the PR comment action always creates a comment, even if the ecosystem results are huge by:
It would be nice if we could add a custom message when the results are truncated but the plugin does not support that. I think this is already a huge improvement because it prevents that we loose the ecosystem result when it's most needed
Test Plan
I commented out the traversal of the class body in checker to generate a large regression.