Avoid allocating in lex_decimal #7252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
dhruvmanila
approved these changes
Sep 9, 2023
konstin
reviewed
Sep 11, 2023
| @@ -1236,6 +1220,49 @@ const fn is_python_whitespace(c: char) -> bool { | |||
| ) | |||
| } | |||
|
|
|||
| enum LexedText<'a> { | |||
There was a problem hiding this comment.
is that the same abstraction we use for normalizing strings?
There was a problem hiding this comment.
The lexer doesn't normalize Strings. I haven't looked into what the whole string.rs is doing (and how much of it could be moved into the lexer)
There was a problem hiding this comment.
i meant in the formatter, this was just a random thought because the logic looked familiar from the normalize functions of strings, ints and floats
There was a problem hiding this comment.
It's similar but we don't use an abstraction in the formatter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lex_decimal_numbershows up as one of the most expensive operations during lexing. This is partially due to it allocating a string before calling intof64::parseorBigInt::parse.This PR avoids allocating a string for numbers that don't use
_orE.Test Plan
cargo testThis improves performance for files with many numbers (dataset.py +3%)