Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore pass-statement-stub-body documentation formatting #7497

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

tjkuson
Copy link
Contributor

@tjkuson tjkuson commented Sep 18, 2023

Summary

Fix CI (broken in #7496).

The code snippet was formatted as Black would format a stub file, but the CI script doesn't know that (it assumes all code snippets are non-stub files). Easier to ignore.

Sorry for breaking CI!

Test Plan

python scripts/check_docs_formatted.py

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 18, 2023

CodSpeed Performance Report

Merging #7497 will improve performances by 4.87%

Comparing tjkuson:fix-ci (49a1d41) with main (bccba5d)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark main tjkuson:fix-ci Change
formatter[large/dataset.py] 61.8 ms 58.9 ms +4.87%

@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@charliermarsh charliermarsh merged commit 359f50e into astral-sh:main Sep 18, 2023
16 checks passed
@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Sep 18, 2023
@charliermarsh
Copy link
Member

Np!

@tjkuson tjkuson deleted the fix-ci branch September 18, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants