Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md to reflect Settings refactor #7555

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update CONTRIBUTING.md to reflect Settings refactor #7555

merged 1 commit into from
Sep 20, 2023

Conversation

charliermarsh
Copy link
Member

Summary

See: #7544 (comment).

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Sep 20, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 20, 2023

CodSpeed Performance Report

Merging #7555 will degrade performances by 2.3%

Comparing charlie/contributing-settings (6971be9) with main (a0917ec)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/contributing-settings Change
❌ linter/default-rules[large/dataset.py] 91.9 ms 94.1 ms -2.3%

@charliermarsh charliermarsh merged commit 86faee1 into main Sep 20, 2023
15 of 16 checks passed
@charliermarsh charliermarsh deleted the charlie/contributing-settings branch September 20, 2023 23:33
@MichaReiser
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @MichaReiser