Disallow f-strings in match pattern literal #7857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/fstring-disallowed-in-match-literal
branch
from
17dd524 to
b08dad3
Compare
dhruvmanila
commented
Oct 9, 2023
| <location:@L> <strings:StringLiteralOrFString+> <end_location:@R> =>? Ok(ast::PatternMatchValue { | ||
| <location:@L> <strings:StringLiteral+> <end_location:@R> =>? Ok(ast::PatternMatchValue { |
There was a problem hiding this comment.
Quite a big diff for a one word change 😅
dhruvmanila
force-pushed
the
dhruv/fstring-disallowed-in-match-literal
branch
from
b08dad3 to
6dae6fc
Compare
konstin
approved these changes
Oct 9, 2023
dhruvmanila
force-pushed
the
dhruv/fstring-disallowed-in-match-literal
branch
from
6dae6fc to
9a3d882
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
konstin
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Summary
This PR fixes a bug to disallow f-strings in match pattern literal.
```
literal_pattern ::= signed_number
| signed_number "+" NUMBER
| signed_number "-" NUMBER
| strings
| "None"
| "True"
| "False"
| signed_number: NUMBER | "-" NUMBER
```
Source:
https://docs.python.org/3/reference/compound_stmts.html#grammar-token-python-grammar-literal_pattern
Also,
```console
$ python /tmp/t.py
File "/tmp/t.py", line 4
case "hello " f"{name}":
^^^^^^^^^^^^^^^^^^
SyntaxError: patterns may only match literals and attribute lookups
```
## Test Plan
Update existing test case and accordingly the snapshots. Also, add a new
test case to verify that the parser does raise an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug to disallow f-strings in match pattern literal.
Source: https://docs.python.org/3/reference/compound_stmts.html#grammar-token-python-grammar-literal_pattern
Also,
Test Plan
Update existing test case and accordingly the snapshots. Also, add a new test case to verify that the parser does raise an error.