Update UP038 docs to note that it results in slower code #7872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Oct 9, 2023
| /// `|`-separated union of types, which is more concise and consistent | ||
| /// `|`-separated union of types, which is consistent |
There was a problem hiding this comment.
I also changed this line, since the rule only makes code more concise if the tuple of types has exactly length 2. If the tuple is 3 elements long, the rule results in code that has exactly the same level of verbosity. If the tuple is 4 or more elements long, the rule results in code that is more verbose than it was originally.
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
konstin
pushed a commit
that referenced
this pull request
Oct 11, 2023
See discussion in #7871. I tried to use language similar to the existing performance warnings in the `flake8-use-pathlib` docs, e.g. https://docs.astral.sh/ruff/rules/os-path-abspath/#os-path-abspath-pth100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #7871. I tried to use language similar to the existing performance warnings in the
flake8-use-pathlibdocs, e.g. https://docs.astral.sh/ruff/rules/os-path-abspath/#os-path-abspath-pth100