Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] Implement PLR0916 (too-many-boolean-expressions) #7975

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

diceroll123
Copy link
Contributor

Summary

Add R0916, no autofix available.

See: #970

Test Plan

cargo test and manually.

@diceroll123 diceroll123 force-pushed the add-PLR0916 branch 4 times, most recently from b82baef to cee646c Compare October 16, 2023 06:44
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+10, -0, 0 error(s))

rotki (+10, -0)

+ rotkehlchen/assets/utils.py:137:9: PLR0916 Too many Boolean expressions (7 > 5)
+ rotkehlchen/chain/ethereum/modules/base_bridge/decoder.py:73:17: PLR0916 Too many Boolean expressions (6 > 5)
+ rotkehlchen/chain/ethereum/modules/compound/decoder.py:194:17: PLR0916 Too many Boolean expressions (6 > 5)
+ rotkehlchen/chain/ethereum/modules/compound/decoder.py:268:17: PLR0916 Too many Boolean expressions (6 > 5)
+ rotkehlchen/chain/ethereum/modules/compound/decoder.py:279:17: PLR0916 Too many Boolean expressions (6 > 5)
+ rotkehlchen/chain/ethereum/modules/curve/decoder.py:202:17: PLR0916 Too many Boolean expressions (6 > 5)
+ rotkehlchen/chain/ethereum/modules/curve/decoder.py:635:17: PLR0916 Too many Boolean expressions (6 > 5)
+ rotkehlchen/chain/ethereum/modules/liquity/decoder.py:139:21: PLR0916 Too many Boolean expressions (6 > 5)
+ rotkehlchen/data_import/importers/binance.py:293:17: PLR0916 Too many Boolean expressions (7 > 5)
+ rotkehlchen/exchanges/kraken.py:1160:25: PLR0916 Too many Boolean expressions (7 > 5)

Rules changed: 1
Rule Changes Additions Removals
PLR0916 10 10 0

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Oct 16, 2023
@charliermarsh charliermarsh changed the title add PLR0916 rule [pylint] Implement PLR0916 (too-many-boolean-expressions) Oct 17, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) October 17, 2023 04:31
@charliermarsh charliermarsh merged commit 21ea290 into astral-sh:main Oct 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants