Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct quick fix message for W605 #8156

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

dhruvmanila
Copy link
Member

Summary

This PR fixes the W605 rule implementation to provide the quickfix message as
per the fix provided.

Test Plan

Update snapshots.

fixes: #8155

@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhruvmanila dhruvmanila added the bug Something isn't working label Oct 24, 2023
@dhruvmanila
Copy link
Member Author

I was working on W605 for the f-string change so just thought to stack it up on top of that.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@dhruvmanila dhruvmanila force-pushed the dhruv/unterminated-fstring branch from c755335 to 1e980fd Compare October 25, 2023 04:22
@dhruvmanila dhruvmanila force-pushed the dhruv/unterminated-fstring branch from 1e980fd to 29fb86e Compare October 25, 2023 13:43
@zanieb zanieb merged commit a7c0258 into dhruv/unterminated-fstring Oct 26, 2023
@zanieb zanieb deleted the dhruv/W605-fix-title branch October 26, 2023 15:37
@zanieb
Copy link
Member

zanieb commented Oct 26, 2023

@dhruvmanila sorry I was very naughty and broke your stack thinking this went into main 😬

@dhruvmanila
Copy link
Member Author

Oh lol, no worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants