Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move type param opening parenthesis comment #8163

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 24, 2023

Summary

This PR fixes the issue to avoid collapsing the type param declaration if
there's a comment after the opening parenthesis. For example,

type foo[  # comment
    A,
    B
] = int

Here, we'll preserve the comment on the same line as is being done for other
similar type of nodes.

Test Plan

Add a new test case for it, update the snapshots, and validate the ecosystem
check.

Formatter ecosystem

main

project similarity index total files changed files
cpython 0.75803 1799 1647
django 0.99983 2772 34
home-assistant 0.99953 10596 186
poetry 0.99891 317 17
transformers 0.99966 2657 330
twine 1.00000 33 0
typeshed 0.99978 3669 20
warehouse 0.99977 654 13
zulip 0.99970 1459 22

dhruv/type-params

project similarity index total files changed files
cpython 0.75803 1799 1647
django 0.99983 2772 34
home-assistant 0.99953 10596 186
poetry 0.99891 317 17
transformers 0.99966 2657 330
twine 1.00000 33 0
typeshed 0.99978 3669 20
warehouse 0.99977 654 13
zulip 0.99970 1459 22

fixes: #8162

@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhruvmanila dhruvmanila added bug Something isn't working formatter Related to the formatter labels Oct 24, 2023
@dhruvmanila dhruvmanila enabled auto-merge (squash) October 24, 2023 11:54
@dhruvmanila dhruvmanila merged commit 2e81b9c into main Oct 24, 2023
16 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/type-params branch October 24, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't move type param opening parenthesis comments
2 participants