Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] Add buffer methods to bad-dunder-method-name (PLW3201) exclusions #8190

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

TeamSpen210
Copy link
Contributor

Summary

Python 3.12 added the __buffer__()/__release_buffer_() special methods, which are incorrectly flagged as invalid dunder methods by PLW3201.

Test Plan

Added definitions to the test suite, and confirmed they failed without the fix and are ignored after the fix was done.

@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@zanieb zanieb added the rule Implementing or modifying a lint rule label Oct 25, 2023
@zanieb zanieb merged commit 8304c41 into astral-sh:main Oct 25, 2023
17 checks passed
@TeamSpen210 TeamSpen210 deleted the buffer-special-method branch October 25, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants