-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unicode flag from comparable #8440
Conversation
Let's hear ecosytem's opinion on that |
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
PLR6201 | 12 | 0 | 12 | 0 | 0 |
PLC0415 | 4 | 0 | 4 | 0 | 0 |
PLR6301 | 1 | 0 | 1 | 0 | 0 |
PLW0108 | 1 | 0 | 1 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
The results doesn't seem related but let me rebase. |
8edb346
to
f721996
Compare
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
\cc @zanieb Shouldn't the ecosystem check update the existing comment? |
Summary
This PR removes the
unicode
flag from the string literal inComparableExpr
. This flag isn't required as all strings are unicode in Python 3 so"foo" == u"foo"
.