Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect implicit returns in auto-return-types #8952

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

charliermarsh
Copy link
Member

Summary

Adds detection for branches without a return or raise, so that we can properly Optional the return types. I'd like to remove this and replace it with our code graph analysis from the unreachable.rs rule, but it at least fixes the worst offenders.

Closes #8942.

@charliermarsh charliermarsh added the bug Something isn't working label Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh charliermarsh marked this pull request as ready for review December 1, 2023 17:34
@charliermarsh charliermarsh merged commit e5db724 into main Dec 1, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/autotyping branch December 1, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autotyping fails to account for implicit returns
1 participant