Iterate over lambdas in deferred type annotations #9175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/defer
branch
from
7918bd9
to
03ef0bb
Compare
MichaReiser
approved these changes
Dec 18, 2023
|
charliermarsh
added a commit
that referenced
this pull request
Jan 16, 2024
## Summary This is effectively the same problem as #9175. And this just papers over it again, though I'm gonna try a more holistic fix in a follow-up PR. The _real_ fix here is that we need to continue to visit deferred items until they're exhausted since, e.g., we still get this case wrong (flagging `re` as unused): ```python import re cast(lambda: re.match, 1) ``` Closes #9534.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9159.