Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set target versions in Black tests #9221

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

MichaReiser
Copy link
Member

Summary

This PR updates our black test importer to parse the --minimum-version header and set the specified value as a Ruff compliant target-version option.

This PR aso updates the most recent black test set

Test Plan

cargo test

@MichaReiser MichaReiser added internal An internal refactor or improvement formatter Related to the formatter labels Dec 21, 2023
@MichaReiser MichaReiser changed the base branch from main to add-target-version-to-formatter-options December 21, 2023 03:19
Copy link
Contributor

github-actions bot commented Dec 21, 2023

ruff-ecosystem results

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Base automatically changed from add-target-version-to-formatter-options to main December 21, 2023 04:06
@MichaReiser MichaReiser force-pushed the set-target-version-in-black-tests branch from d87ba74 to 390adb4 Compare December 21, 2023 04:14
@MichaReiser MichaReiser changed the title Add target_version to formatter options Set target versions in Black tests Dec 21, 2023
@MichaReiser MichaReiser enabled auto-merge (squash) December 21, 2023 04:15
@MichaReiser MichaReiser merged commit c6d8076 into main Dec 21, 2023
16 checks passed
@MichaReiser MichaReiser deleted the set-target-version-in-black-tests branch December 21, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants