Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cell indexes to all diagnostics #9387

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add cell indexes to all diagnostics #9387

merged 1 commit into from
Jan 4, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Ensures that any lint rules that include line locations render them as relative to the cell (and include the cell number) when inside a Jupyter notebook.

Closes #6672.

Test Plan

cargo test

@charliermarsh charliermarsh added the bug Something isn't working label Jan 4, 2024
@charliermarsh charliermarsh marked this pull request as ready for review January 4, 2024 02:45
Copy link
Contributor

github-actions bot commented Jan 4, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

ibis-project/ibis (error)

Failed to clone ibis-project/ibis: warning: Could not find remote branch master to clone.
fatal: Remote branch master not found in upstream origin

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

ibis-project/ibis (error)

ruff check --no-cache --exit-zero --preview

Failed to clone ibis-project/ibis: warning: Could not find remote branch master to clone.
fatal: Remote branch master not found in upstream origin

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

ibis-project/ibis (error)

Failed to clone ibis-project/ibis: warning: Could not find remote branch master to clone.
fatal: Remote branch master not found in upstream origin

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

ibis-project/ibis (error)

ruff format --preview

Failed to clone ibis-project/ibis: warning: Could not find remote branch master to clone.
fatal: Remote branch master not found in upstream origin

crates/ruff_source_file/src/lib.rs Outdated Show resolved Hide resolved
@charliermarsh charliermarsh enabled auto-merge (squash) January 4, 2024 13:57
@charliermarsh charliermarsh merged commit 328262b into main Jan 4, 2024
16 checks passed
@charliermarsh charliermarsh deleted the charlie/row branch January 4, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F811: Message unclear in Notebook context
2 participants