Recategorize static-key-dict-comprehension from RUF011 to B035
#9428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
changed the title
RUF011 to B035static-key-dict-comprehension from RUF011 to B035
|
A few questions here to understand if this is safe to land under our versioning policy or if we need to delay it to the next
This is more of a question for our versioning policy: If I remember correctly, this changes the rule codes in diagnostics. We may need to consider this a breaking change because GitLab and other tools that track diagnostics over time now consider the RUF011 diagnostics as fixed but reports new B035 diagnostics. |
|
Yeah, we may need to ship this as part of
|
charliermarsh
force-pushed
the
charlie/B035
branch
3 times, most recently
from
1867b11
to
9558c11
Compare
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 1 | 1 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)
RasaHQ/rasa (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --preview
+ tests/graph_components/validators/test_default_recipe_validator.py:815:64: RUF100 [*] Unused `noqa` directive (non-enabled: `B035`)
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 1 | 1 | 0 | 0 | 0 |
charliermarsh
force-pushed
the
charlie/B035
branch
from
9558c11
to
c2e7413
Compare
charliermarsh
force-pushed
the
charlie/B035
branch
from
c2e7413
to
ec2b7e6
Compare
charliermarsh
force-pushed
the
charlie/B035
branch
from
ec2b7e6
to
2634029
Compare
Merged
zanieb
pushed a commit
that referenced
this pull request
Jan 29, 2024
…9428) ## Summary This rule was added to flake8-bugbear. In general, we tend to prefer redirecting to prominent plugins when our own rules are reimplemented (since more projects have `B` activated than `RUF`). ## Test Plan `cargo test`
zanieb
pushed a commit
that referenced
this pull request
Jan 30, 2024
…9428) ## Summary This rule was added to flake8-bugbear. In general, we tend to prefer redirecting to prominent plugins when our own rules are reimplemented (since more projects have `B` activated than `RUF`). ## Test Plan `cargo test`
zanieb
added a commit
that referenced
this pull request
Feb 1, 2024
…9428) ## Summary This rule was added to flake8-bugbear. In general, we tend to prefer redirecting to prominent plugins when our own rules are reimplemented (since more projects have `B` activated than `RUF`). ## Test Plan `cargo test` # Conflicts: # crates/ruff_linter/src/rules/ruff/rules/mod.rs
zanieb
added a commit
that referenced
this pull request
Feb 1, 2024
zanieb
added a commit
that referenced
this pull request
Feb 1, 2024
…9428) ## Summary This rule was added to flake8-bugbear. In general, we tend to prefer redirecting to prominent plugins when our own rules are reimplemented (since more projects have `B` activated than `RUF`). ## Test Plan `cargo test` # Conflicts: # crates/ruff_linter/src/rules/ruff/rules/mod.rs
zanieb
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This rule was added to flake8-bugbear. In general, we tend to prefer redirecting to prominent plugins when our own rules are reimplemented (since more projects have
Bactivated thanRUF).Test Plan
cargo test