Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pyproject_config into Resolver #9453

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Move pyproject_config into Resolver #9453

merged 1 commit into from
Jan 10, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jan 10, 2024 •
edited
Loading

Summary

Sort of a random PR to make the coupling between pyproject_config and resolver more explicit by passing it to the Resolver, rather than threading it through to each individual method.

@charliermarsh charliermarsh added the internal An internal refactor or improvement label Jan 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh charliermarsh marked this pull request as ready for review January 10, 2024 21:43
@charliermarsh charliermarsh merged commit 4a3bb67 into main Jan 10, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/resolver branch January 10, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @zanieb