Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pygrep_hooks] Add fix for deprecated-log-warn (PGH002) #9519

Merged
merged 6 commits into from
Jan 16, 2024
Merged

[pygrep_hooks] Add fix for deprecated-log-warn (PGH002) #9519

merged 6 commits into from
Jan 16, 2024

Conversation

diceroll123
Copy link
Contributor

Summary

add autofix for deprecated_log_warn (PGH002)

Test Plan

cargo test

@diceroll123 diceroll123 force-pushed the add-autofix-for-PGH002 branch from 3fa71c8 to 8f676f3 Compare January 15, 2024 02:45
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 15, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9519 will not alter performance

Comparing diceroll123:add-autofix-for-PGH002 (6f85308) with main (f9331c7)

Summary

✅ 30 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

charliermarsh
charliermarsh approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@charliermarsh charliermarsh added the preview Related to preview mode features label Jan 16, 2024
@charliermarsh charliermarsh changed the title [pygrep_hooks] - add autofix for deprecated_log_warn (PGH002) [pygrep_hooks] Add fix for deprecated-log-warn (PGH002) Jan 16, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) January 16, 2024 02:29
@charliermarsh charliermarsh enabled auto-merge (squash) January 16, 2024 02:34
@charliermarsh charliermarsh enabled auto-merge (squash) January 16, 2024 02:48
@charliermarsh charliermarsh merged commit 2bddde2 into astral-sh:main Jan 16, 2024
17 checks passed
@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Jan 16, 2024
@branchvincent branchvincent mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations preview Related to preview mode features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diceroll123 @charliermarsh