Detect automagic-like assignments in notebooks #9653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given a statement like
colors = 6
, we currently treat the cell as an automagic (sincecolors
is an automagic) -- i.e., we assume it's equivalent to%colors = 6
. This PR adds some additional detection whereby if the statement is an assignment, we avoid treating it as such. I audited the list of automagics, and I believe this is safe for all of them.Closes #8526.
Closes #9648.
Test Plan
cargo test