-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pep508_rs and pep440_rs #928
Conversation
This is in an attempt to solve #912. In this case by using the real absolute path as the Url part of VerbatimUrl and the ${PROJECT_ROOT}/../relative path as the "given" part of the URL, let's see how that works out. Remains to be done
|
33aa30d
to
81ac63f
Compare
69a8d4a
to
1d89d54
Compare
Now it's working, but it certainly does not feel solid around VerbatimUrl and ${}'s. |
2ce0036
to
fc91d87
Compare
rebased x3 |
Feedback on this is welcome. Updating these crates is ok? Fixing relative paths is ok or a bad idea? We could go other ways, like adopting another convention for relative paths than the |
Can you explain why the original failure is happening? I.e., why is |
The bug is just general to rye add with relative paths. The default This bug shows up in for example So we could say that ${PROJECT_ROOT} is always problematic for rye add currently - it seems to work in rye sync though. This PR is my attempt to fix this in a "minimal" way. It's not great that the PR mixes two things - updating deps and fixing bugs in add, but when I wrote this I didn't want to leave stuff in a half broken state. (I even had the energy to write tests. They are not there because I'm a nice guy, it's because I want this functionality to keep working 😉 ) |
There's a lot more we'd like to do with relative paths, but I need some buy in from @mitsuhiko I feel. It would be great to adopt some ideas from uv where you have done the hard work of finding out what's interoperable with pip and what is not - see PR astral-sh/uv#3682 |
Update pep508_rs and pep440_rs crates Main reason is to use VerbatimUrl from pep508_rs. Note that monotrail-utils is still using the older pep508_rs.
For test uniformity, set author name in test config.
rebased and dropped the changelog update because the newest changelog seemed to be autogenerated |
This is to explicitly use / for path separators.
Will close |
Update pep508_rs and pep440_rs crates
Main reason is to use VerbatimUrl from pep508_rs and try to fix issues around file:///${PROJECT_ROOT}/etc dependencies.
Note that monotrail-utils is still using the older pep508_rs.
Fixes #912