-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove
flatten
to improve deserialization error messages (#7598)
## Summary `#[serde(flatten)]` has a disastrous effect on error messages: serde no longer tells you which field errored, nor does it show it to you in the diagnostic output. Before: ``` warning: Failed to parse `pyproject.toml` during settings discovery: TOML parse error at line 9, column 1 | 9 | [tool.uv] | ^^^^^^^^^ invalid type: string "foo", expected a sequence ``` After: ``` warning: Failed to parse `pyproject.toml` during settings discovery: TOML parse error at line 10, column 19 | 10 | extra-index-url = "foo" | ^^^^^ invalid type: string "foo", expected a sequence ``` Closes #7113.
- Loading branch information
1 parent
85af273
commit 86ff740
Showing
4 changed files
with
240 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.