Skip to content

Commit

Permalink
Fix references to --resolution-strategy in error message output (#8971
Browse files Browse the repository at this point in the history
)

Closes #8967.
  • Loading branch information
charliermarsh authored Nov 9, 2024
1 parent f508ef0 commit 8a3e5d4
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion crates/uv-distribution-types/src/resolution.rs
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ impl Diagnostic for ResolutionDiagnostic {
format!(
"The transitive dependency `{name}` is unpinned. \
Consider setting a lower bound with a constraint when using \
`--resolution-strategy lowest` to avoid using outdated versions."
`--resolution lowest` to avoid using outdated versions."
)
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/uv-resolver/src/resolver/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2212,7 +2212,7 @@ impl ForkState {
if !has_url && missing_lower_bound && strategy_lowest {
warn_user_once!(
"The direct dependency `{package}` is unpinned. \
Consider setting a lower bound when using `--resolution-strategy lowest` \
Consider setting a lower bound when using `--resolution lowest` \
to avoid using outdated versions."
);
}
Expand Down
6 changes: 3 additions & 3 deletions crates/uv/tests/it/lock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7814,9 +7814,9 @@ fn lock_warn_missing_transitive_lower_bounds() -> Result<()> {

----- stderr -----
Resolved 6 packages in [TIME]
warning: The transitive dependency `colorama` is unpinned. Consider setting a lower bound with a constraint when using `--resolution-strategy lowest` to avoid using outdated versions.
warning: The transitive dependency `packaging` is unpinned. Consider setting a lower bound with a constraint when using `--resolution-strategy lowest` to avoid using outdated versions.
warning: The transitive dependency `iniconfig` is unpinned. Consider setting a lower bound with a constraint when using `--resolution-strategy lowest` to avoid using outdated versions.
warning: The transitive dependency `colorama` is unpinned. Consider setting a lower bound with a constraint when using `--resolution lowest` to avoid using outdated versions.
warning: The transitive dependency `packaging` is unpinned. Consider setting a lower bound with a constraint when using `--resolution lowest` to avoid using outdated versions.
warning: The transitive dependency `iniconfig` is unpinned. Consider setting a lower bound with a constraint when using `--resolution lowest` to avoid using outdated versions.
"###);

Ok(())
Expand Down
4 changes: 2 additions & 2 deletions crates/uv/tests/it/pip_compile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11474,7 +11474,7 @@ fn compile_index_url_unsafe_lowest() -> Result<()> {
# via -r requirements.in
----- stderr -----
warning: The direct dependency `anyio` is unpinned. Consider setting a lower bound when using `--resolution-strategy lowest` to avoid using outdated versions.
warning: The direct dependency `anyio` is unpinned. Consider setting a lower bound when using `--resolution lowest` to avoid using outdated versions.
Resolved 1 package in [TIME]
"###
);
Expand Down Expand Up @@ -13184,7 +13184,7 @@ fn lowest_fork() -> Result<()> {
----- stderr -----
Resolved 3 packages in [TIME]
warning: The transitive dependency `setuptools` is unpinned. Consider setting a lower bound with a constraint when using `--resolution-strategy lowest` to avoid using outdated versions.
warning: The transitive dependency `setuptools` is unpinned. Consider setting a lower bound with a constraint when using `--resolution lowest` to avoid using outdated versions.
"###
);

Expand Down

0 comments on commit 8a3e5d4

Please sign in to comment.