Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv lock should not run build backend for dynamic versions #10689

Closed
danielhollas opened this issue Jan 16, 2025 · 0 comments · Fixed by #10703
Closed

uv lock should not run build backend for dynamic versions #10689

danielhollas opened this issue Jan 16, 2025 · 0 comments · Fixed by #10703
Assignees
@charliermarsh

Comments

@danielhollas
Copy link
Contributor

uv lock still invokes the build backend even after the project's dynamic version has been omited from uv.lock in #10622.

We're hitting this over at astral-sh/uv-pre-commit#35

Originally posted by @danielhollas in #10622 (comment)

@charlieMarsh mentioned that this is a TODO in the code, I guess it is this one:

https://github.com/astral-sh/uv/pull/10622/files#diff-94a57a0e91f87a94e015da3bd8f9e8660ce3c8564718e78ee6599a3e214965d3R1230
@charliermarsh charliermarsh self-assigned this Jan 16, 2025
This was referenced Jan 16, 2025
Closed
Merged
@charliermarsh charliermarsh mentioned this issue Jan 17, 2025
Merged
charliermarsh added a commit that referenced this issue Jan 17, 2025
@charliermarsh
Avoid building dynamic versions when validating lockfile (#10703)
80bdb3a 
## Summary

Closes #10689.
@danielhollas danielhollas mentioned this issue Jan 17, 2025
Closed
dangotbanned added a commit to vega/altair that referenced this issue Jan 18, 2025
@dangotbanned
ci(uv): Remove dynamic version from uv.lock
6ca0465 
Seems to have been a bug that was resolved in astral-sh/uv#10689

Essentially, each time I've switched branches this change keeps trying to happen.
@dangotbanned dangotbanned mentioned this issue Jan 18, 2025
Merged
agoscinski pushed a commit to aiidateam/aiida-core that referenced this issue Jan 24, 2025
@danielhollas
Use uv-pre-commit to validate lockfile (#6699)
208d6a9 
The previous uv hook that checked whether uv lockfile is up-to-date required
the developer to have uv installed. Using the official uv-pre-commit hook, this
is no longer the case. The hook also updates the lock automatically, instead of
just checking its status.

Bump minimum version of uv to `0.5.21` fix issue
astral-sh/uv#10689 uv does run the build backend for
projects with dynamic versioning.

Bump astral-sh/setup-uv action to v5.2.1.

Change in `.github/workflows/ci-code.yml` (`file` -> `files`) is related to
fixing a warning in the CI.
unkcpz pushed a commit to unkcpz/aiida-core that referenced this issue Jan 28, 2025
@danielhollas @unkcpz
Use uv-pre-commit to validate lockfile (aiidateam#6699)
df65548 
The previous uv hook that checked whether uv lockfile is up-to-date required
the developer to have uv installed. Using the official uv-pre-commit hook, this
is no longer the case. The hook also updates the lock automatically, instead of
just checking its status.

Bump minimum version of uv to `0.5.21` fix issue
astral-sh/uv#10689 uv does run the build backend for
projects with dynamic versioning.

Bump astral-sh/setup-uv action to v5.2.1.

Change in `.github/workflows/ci-code.yml` (`file` -> `files`) is related to
fixing a warning in the CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid building dynamic versions when validating lockfile astral-sh/uv
2 participants
@charliermarsh @danielhollas