-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow duplicates of the same version of the same package #1552
Comments
pip-tools works as expected:
pip-tools will only fail if there are incompatible requirements found:
I'd like to see both behaviors in uv too. |
I think this makes sense, though I'm not sure what should happen if the requirements overlap? E.g., |
pip-sync seems to work only when the duplicated requirements are exactly the same, otherwise it will fail with
|
Fixed in #1558. |
## Summary It turns out that it's not uncommon to end up with repeated packages in requirements files when running `pip-sync`, e.g., you might have `anyio==4.0.0` specified multiple times. This PR relaxes our assertions in the install plan to allow such repeated packages, as long as the requirement markers are exactly the same (i.e., they are truly duplicates). Closes #1552.
we have multiple requirements.txt files with the same package at the same version (thanks to
pip-sync -c requirements1.txt requirements2.in
)I think the check here is too strict
uv/crates/uv-installer/src/plan.rs
Lines 125 to 130 in 4e0b6f8
The text was updated successfully, but these errors were encountered: