-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No type annotations for find_uv_bin #1677
Comments
Hi! This is not a public function, We could consider exposing |
In the world of Python |
I mean, it's Python everything is "public". I don't think |
That's not true by convention anything starting with an underscore is considered private. Magic modules are also considered public as far as I understand, so yes, they are meant to be importable. They just also serve another functionality on top of that. |
I would strongly discourage you from importing from our It looks like it does have type annotations already? I'm happy to add a |
Resolves #1677 Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
I'm using
find_uv_bin
inside https://github.com/tox-dev/tox-uv/blob/main/src/tox_uv/_venv.py#L14, but mypy complain that this method is not exposed (no__all__
containing it) and also no type annotations for it (because https://peps.python.org/pep-0561/#packaging-type-information is missing from the Python package, plus actual type annotations for it)The text was updated successfully, but these errors were encountered: