Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer system TLS cert store by default #2409

Closed
DragoonAethis opened this issue Mar 13, 2024 · 3 comments · Fixed by #2412
Closed

Prefer system TLS cert store by default #2409

DragoonAethis opened this issue Mar 13, 2024 · 3 comments · Fixed by #2412
Assignees
Labels
configuration Settings and such question Asking for clarification or support

Comments

@DragoonAethis
Copy link

This is a follow-up on #2362 where bundled root cert stores became the default.

In scenarios where uv is wrapped by another rool (like rye) or buried somewhere deep in layers of Makefiles, "just" adding a command-line flag might not be trivial to make things work again. This change affects both users behind corporate HTTPS inspection proxies and private registry clients, where the registry is not world-facing but rather available only on the intranet with an internal cert issuer.

While I understand this makes initial startup benchmarks look rather bad, it also makes uv a pain to use in corporate environments. Please reconsider the default behavior to respect the system root cert store again, or at least make this configurable from environment variables/configuration files.

@samypr100
Copy link
Collaborator

samypr100 commented Mar 13, 2024

This is partially fixed by #2401 if you have a ca bundle file.

We can go a bit further and add another env var as a shothand to --native-tls.

This change would be in uv crate itself and not in uv-client crate.

@charliermarsh
Copy link
Member

No problem, I'll add an environment variable for it.

While I understand this makes initial startup benchmarks look rather bad, it also makes uv a pain to use in corporate environments.

It's actually not even about benchmarks -- there's minimal overhead on Linux. But I use macOS and it makes uv ~50-100x slower on basic commands.

@charliermarsh charliermarsh self-assigned this Mar 13, 2024
@zanieb zanieb added the question Asking for clarification or support label Mar 13, 2024
@charliermarsh charliermarsh added the configuration Settings and such label Mar 13, 2024
charliermarsh added a commit that referenced this issue Mar 13, 2024
@DragoonAethis
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Settings and such question Asking for clarification or support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants