Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheel selection needs to break ties based on build tag #3779

Closed
charliermarsh opened this issue May 23, 2024 · 0 comments · Fixed by #3781
Closed

Wheel selection needs to break ties based on build tag #3779

charliermarsh opened this issue May 23, 2024 · 0 comments · Fixed by #3781
Assignees
@charliermarsh
Labels
bug Something isn't working compatibility Compatibility with a specification or another tool

Comments

@charliermarsh
Copy link
Member

See: #2538 (comment).
@charliermarsh charliermarsh added bug Something isn't working compatibility Compatibility with a specification or another tool labels May 23, 2024
@charliermarsh charliermarsh self-assigned this May 23, 2024
@charliermarsh charliermarsh mentioned this issue May 23, 2024
Merged
charliermarsh added a commit that referenced this issue May 23, 2024
@charliermarsh
Incorporate build tag into wheel prioritization (#3781)
a9d9a6c 
## Summary

It turns out that in the
[spec](https://packaging.python.org/en/latest/specifications/binary-distribution-format/#file-name-convention),
if a wheel filename includes a build tag, then we need to use it to
break ties. This PR implements that behavior. (Previously, we dropped
the build tag entirely.)

Closes #3779.

## Test Plan

Run: `cargo run pip install -i https://pypi.anaconda.org/intel/simple
mkl_fft==1.3.8 --python-platform linux --python-version 3.10`. This now
resolves without error. Previously, we selected build tag 63 of
`mkl_fft==1.3.8`, which led to an incompatibility with NumPy. Now, we
select build tag 70.
@jonded94 jonded94 mentioned this issue Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working compatibility Compatibility with a specification or another tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Incorporate build tag into wheel prioritization astral-sh/uv
1 participant
@charliermarsh