Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent 401 in test cases with authentication #6167

Closed
zanieb opened this issue Aug 17, 2024 · 1 comment · Fixed by #6182
Closed

Intermittent 401 in test cases with authentication #6167

zanieb opened this issue Aug 17, 2024 · 1 comment · Fixed by #6182
Labels
internal A refactor or improvement that is not user-facing testing Internal testing of behavior

Comments

@zanieb
Copy link
Member

zanieb commented Aug 17, 2024

We're seeing intermittent HTTP 401 Unauthorized errors in our test suite.
@zanieb zanieb added internal A refactor or improvement that is not user-facing testing Internal testing of behavior labels Aug 17, 2024
@zanieb
Copy link
Member Author

zanieb commented Aug 18, 2024 •
edited
Loading

lock_redact_https in https://github.com/astral-sh/uv/actions/runs/10441180546/job/28912009907?pr=6172 failed with

        6 │+thread 'uv-resolver' panicked at [WORKSPACE]/crates/uv-resolver/src/resolver/mod.rs:274:33:
        7 │+called `Result::unwrap()` on an `Err` value: Err(ChannelClosed)
        8 │+note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@zanieb zanieb mentioned this issue Aug 18, 2024
Merged
zanieb added a commit that referenced this issue Aug 18, 2024
@zanieb
Avoid panicking when the resolver thread encounters a closed channel (#…
baf17be 
…6182)

Closes #6167

We've been seeing intermittent failures in CI, which we thought were
unexpected HTTP 401s but it actually looks like a panic when handling an
expected HTTP error. I believe the problem is that an early client error
can cause the channel to close and we crash when we unwrap the `send`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing testing Internal testing of behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid panicking when the resolver thread encounters a closed channel astral-sh/uv
1 participant
@zanieb