Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv shouldn't modify pyproject.toml on failed install #7011

Closed
kdheepak opened this issue Sep 4, 2024 · 3 comments · Fixed by #7022
Closed

uv shouldn't modify pyproject.toml on failed install #7011

kdheepak opened this issue Sep 4, 2024 · 3 comments · Fixed by #7022
Assignees
@charliermarsh
Labels
bug Something isn't working

Comments

@kdheepak
Copy link
Contributor

kdheepak commented Sep 4, 2024

I ran the following:

$ uv add dsfkdsjfldskfjds
error: Request failed after 3 retries
  Caused by: error sending request for url (https://pypi.org/simple/dsfkdsjfldskfjds/)
  Caused by: client error (Connect)
  Caused by: invalid peer certificate: UnknownIssuer

But that resulted in a change to pyproject.toml:

image
@kdheepak
Copy link
Contributor Author

kdheepak commented Sep 4, 2024

This seems to happen only if there's a certificate failure. After setting export UV_NATIVE_TLS=true, and running the same thing, I get a different error:

image

But this time dependencies is not updated in pyproject.toml.

@charliermarsh
Copy link
Member

Interesting, thanks.

@charliermarsh charliermarsh added the bug Something isn't working label Sep 4, 2024
@charliermarsh charliermarsh self-assigned this Sep 4, 2024
@zanieb
Copy link
Member

zanieb commented Sep 4, 2024

Ah I encountered this too recently.

@charliermarsh charliermarsh mentioned this issue Sep 4, 2024
Merged
charliermarsh added a commit that referenced this issue Sep 4, 2024
@charliermarsh
Rollback pyproject.toml changes on all errors (#7022)
e7c9a9c 
## Summary

The error handlers now happen one level higher, matching on _any_ `Err`
that's returned from the lock-and-sync operations.

Closes #7011.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rollback pyproject.toml changes on all errors astral-sh/uv
3 participants
@charliermarsh @kdheepak @zanieb