Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

venv/activate uses zsh-specific syntax #7480

Open
prez opened this issue Sep 17, 2024 · 1 comment · Fixed by #10397
Open

venv/activate uses zsh-specific syntax #7480

prez opened this issue Sep 17, 2024 · 1 comment · Fixed by #10397
Assignees
Labels
bug Something isn't working

Comments

@prez
Copy link

prez commented Sep 17, 2024

I'm using the yash shell, which is strictly POSIX-compliant and errors out on . .venv/bin/activate.

The snippet using a zsh-specific extension is SCRIPT_PATH="${(%):-%x}" in line 34.

Please take a look at the original issue (I filed this with yash at first) for some context and a potential fix: magicant/yash#62

Thank you.

@charliermarsh charliermarsh added the bug Something isn't working label Sep 18, 2024
@Gankra Gankra closed this as completed in 2f7f9ea Jan 8, 2025
charliermarsh added a commit that referenced this issue Jan 11, 2025
#10497)

## Summary

This reverts commit 2f7f9ea
(#10397). We're seeing some
user-reported failures, so we need to investigate further before
re-shipping.

Re-opens #7480.

Closes #10487.
@notatallshaw
Copy link
Collaborator

Fix was reverted

@notatallshaw notatallshaw reopened this Jan 11, 2025
@Gankra Gankra self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants