Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init_app_build_backend_maturin test timed out on macOS #8404

Closed
zanieb opened this issue Oct 21, 2024 · 8 comments · Fixed by #8447
Closed

init_app_build_backend_maturin test timed out on macOS #8404

zanieb opened this issue Oct 21, 2024 · 8 comments · Fixed by #8447
Labels
internal A refactor or improvement that is not user-facing

Comments

@zanieb
Copy link
Member

zanieb commented Oct 21, 2024

--- STDERR:              uv::it init::init_app_build_backend_maturin ---

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Unfiltered output ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
----- stdout -----

----- stderr -----
Initialized project `foo`

────────────────────────────────────────────────────────────────────────────────


     TIMEOUT [  90.027s] uv::it init::init_lib_build_backend_maturin
@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Oct 21, 2024
@zanieb zanieb changed the title init_app_build_backend_maturin timed out on macOS init_app_build_backend_maturin test timed out on macOS Oct 21, 2024
@konstin
Copy link
Member

konstin commented Oct 21, 2024

Can you see where it got stuck?

@zanieb
Copy link
Member Author

zanieb commented Oct 21, 2024

Unfortunately no, that's all I got.

@zanieb
Copy link
Member Author

zanieb commented Oct 21, 2024

@zanieb
Copy link
Member Author

zanieb commented Oct 21, 2024

Wow these tests are just insanely slow to begin with

        SLOW [  46.554s] uv::it init::init_app_build_backend_maturin
        SLOW [  45.017s] uv::it init::init_lib_build_backend_maturin

I bet it's just a bit slower sometimes and times out. It runs in 7s on my machine — I couldn't reproduce a timeout locally. Regardless, this just seems like an unacceptably slow unit test.

@konstin
Copy link
Member

konstin commented Oct 21, 2024

We can speed them up by switching to cffi (no rust deps), pyo3 is quite slow to compile in an uncached integration test (PyO3/maturin#2272).

@zanieb
Copy link
Member Author

zanieb commented Oct 21, 2024

I'm not sure how to do that, but that makes sense to me.

konstin added a commit that referenced this issue Oct 22, 2024
Building pyo3 is slow, and we don't implement a maturin cffi template (not enough usage), so we just skip the building pyo3 stage.

Closes #8404
@davidhewitt
Copy link

Was part of the problem that the tests were building release binaries? I wonder if setting MATURIN_PEP517_ARGS=--profile=dev might have helped if so.

@konstin
Copy link
Member

konstin commented Nov 26, 2024

At least in the maturin test suite itself, even building with dev is slow, and the cache artifacts would be too large to store (PyO3/maturin#2272)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants