Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when using the keyring in uv publish but it doesn't have credentials #8781

Closed
Tracked by #7839
konstin opened this issue Nov 3, 2024 · 1 comment · Fixed by #8827
Closed
Tracked by #7839

Warn when using the keyring in uv publish but it doesn't have credentials #8781

konstin opened this issue Nov 3, 2024 · 1 comment · Fixed by #8827
Labels
enhancement New feature or improvement to existing functionality error messages Messaging when something goes wrong

Comments

@konstin
Copy link
Member

konstin commented Nov 3, 2024

See #7963 (comment): We should warn in this case that the keyring didn't return any password, since using the keyring with publishing only makes sense if it has a password for the publish URL
@konstin konstin added enhancement New feature or improvement to existing functionality error messages Messaging when something goes wrong labels Nov 3, 2024
@cthoyt
Copy link
Contributor

cthoyt commented Nov 4, 2024

Thanks @konstin for following up on this. Such a test could also make a specific test when you use --publish-url https://test.pypi.org/legacy/ and there's no credentials but there is something like https://test.pypi.org/legacy/?PACKAGE available - it could say "hey, you might want to use a package-specific publish URL that has the following form where ?PACKAGE is your package`.

Should uv go even further to guess the right publish URL in keyring based on the current package name? Can uv publish even introspect on that metadata?

@konstin konstin mentioned this issue Nov 4, 2024
Open
18 tasks
konstin added a commit that referenced this issue Nov 5, 2024
@konstin
Publish: Warn when keyring has no password
051b9df 
When trying to upload without a password but with the keyring, check that the keyring has a password for the upload URL and username and warn if it doesn't.

Fixes #8781
konstin added a commit that referenced this issue Nov 5, 2024
@konstin
Publish: Warn when keyring has no password
9dce516 
When trying to upload without a password but with the keyring, check that the keyring has a password for the upload URL and username and warn if it doesn't.

Fixes #8781
@konstin konstin mentioned this issue Nov 5, 2024
Merged
konstin added a commit that referenced this issue Nov 27, 2024
@konstin
Publish: Warn when keyring has no password (#8827)
0b0d0f4 
When trying to upload without a password but with the keyring, check
that the keyring has a password for the upload URL and username and warn
if it doesn't.

Fixes #8781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement to existing functionality error messages Messaging when something goes wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish: Warn when keyring has no password astral-sh/uv
2 participants
@cthoyt @konstin