-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uv
appears to be locking incorrect transitive dependencies when used by Renovate on pyscss
with python 3.11
#9217
Comments
Ah, we generally don't respect upper-bounds on |
I've had a bit of a read through that linked conversation and I think it's a slightly different thing. Apologies if I'm misunderstanding. I think what you're saying, and what that conversation is broadly talking about, is: if a transitive dependency says it's not compatible with eg python 3.4+, that upper bound is broadly ignored. This feels slightly different - So it's not really that the transitive dependency has an upper bound on But maybe that distinction isn't relevant here and both are treated the same way? Either way - also slightly curious about why the lockfile would be different on Renovate's system compared to mine 🤔 |
pyscss doesn't use environment markers, it looks at I assume the difference locally is because you installed the package which populated the cache with a wheel that has the correct metadata. |
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
When running in Renovate, uv is incorrectly including enum34 and pathlib2 as transitive dependencies of pyscss. pyscss only requires these for python versions below 3.4, but something in the dependency resolver is getting this wrong. astral-sh/uv#9217 A fix doesn't seem to be coming imminently. pyscss is a very old and unmaintained package that we should probably look to move away from sooner or later.
Please tell us more about your question or problem
I'm using https://docs.renovatebot.com/ to keep project dependencies up to date. This supports
uv.lock
and uses nativeuv
commands to update the lockfile when bumping mainline deps.I've noticed that it is pulling in invalid transitive dependencies for
pyscss
on a python 3.11 project (for example).Please see example of incorrect transitive dependency locking: https://github.com/samuelhwilliams/test-renovate-uv/pull/1/files
I initially raised this on renovate's repo, but they've pointed out that they use
uv
commands directly so the issue feels unlikely to be wholly on their side.On a python 3.11+ project that pulls in
pyscss
, renovate is addingenum34
andpathlib2
as transitive dependencies.pyscss
declares these as dependencies only on versions lower than python 3.4. Pulling these in, specifically enum34, can break the python stdlib in unusual ways (becauseenum34
imports asenum
, which overrides the stdlibenum
, which is used by other stdlibs but has a different interface).If I pull the renovate branch locally and run
uv remove pyscss
anduv add pyscss==1.4.0
, enum34 and pathlib2 are removed from the lockfile again. So possibly there's some interaction with how they setup their environment, but from my quick scan of the logs it looks reasonably correct.See renovate logs below - searching for
uv lock
and/orenum34
shows that these are getting added natively byuv
.Logs (if relevant)
Logs
The text was updated successfully, but these errors were encountered: