Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv-pep440: adds an explicit test for trailing zeros #10362

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

BurntSushi
Copy link
Member

Basically, this explicitly checks that parsing a 1.2.0 into a
Version will roundtrip back to a 1.2.0, and that parsing a 1.2
will roundtrip back to a 1.2.

I think this case is included in the other tests in this module, but
this test makes the behavior more clearly intentional I think.

Ref #10345

Basically, this explicitly checks that parsing a `1.2.0` into a
`Version` will roundtrip back to a `1.2.0`, and that parsing a `1.2`
will roundtrip back to a `1.2`.

I think this case is included in the other tests in this module, but
this test makes the behavior more clearly intentional I think.

Ref #10345
@BurntSushi BurntSushi requested a review from konstin January 7, 2025 14:06
@BurntSushi BurntSushi enabled auto-merge (squash) January 7, 2025 14:10
@BurntSushi BurntSushi merged commit fb29445 into main Jan 7, 2025
64 checks passed
@BurntSushi BurntSushi deleted the ag/pep440-add-trailing-zero-test branch January 7, 2025 14:16
BurntSushi added a commit that referenced this pull request Jan 7, 2025
This happened as a result of #10345 and #10362 being merged
independently. The latter used the old `Version::release` API, but the
former changed the `Version::release` API. This PR tweaks the new test
to use the new API (i.e., force a deref on the proxy type).
BurntSushi added a commit that referenced this pull request Jan 7, 2025
This happened as a result of #10345 and #10362 being merged
independently. The latter used the old `Version::release` API, but the
former changed the `Version::release` API. This PR tweaks the new test
to use the new API (i.e., force a deref on the proxy type).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants