Add a GitHub repository struct to uv-git
#10768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
internal
charliermarsh
force-pushed
the
charlie/github
branch
from
7724a74 to
e78c04b
Compare
charliermarsh
commented
Jan 20, 2025
| let response_code = response.status(); | ||
| if response_code == StatusCode::NOT_MODIFIED { | ||
| Ok(FastPathRev::UpToDate) | ||
| } else if response_code == StatusCode::OK { | ||
| let oid_to_fetch = response.text().await?.parse()?; | ||
| Ok(FastPathRev::NeedsFetch(oid_to_fetch)) | ||
| } else { | ||
| // Usually response_code == 404 if the repository does not exist, and | ||
| // response_code == 422 if exists but GitHub is unable to resolve the | ||
| // requested rev. |
There was a problem hiding this comment.
This is in the wrong place. 400-level errors are raised by response.error_for_status_ref()?!
charliermarsh
commented
Jan 20, 2025
| /// repository, like `astral-sh`. | ||
| pub owner: &'a str, | ||
| /// The `repo` field for the repository, i.e., the name of the repository, like `uv`. | ||
| pub repo: &'a str, |
There was a problem hiding this comment.
Uses the terminology of the GitHub API.
konstin
approved these changes
Jan 20, 2025
Co-authored-by: konsti <konstin@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is useful for #10765, but we already have one usage today, so carving it out into a standalone PR.