Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in-memory locks from distribution database #11412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charliermarsh
Copy link
Member

Summary

I believe these are not necessary... They're currently used in two places:

  1. When building wheels. But that's already wrapped in an in-flight map, which does the same thing.
  2. When fetching source distribution metadata. But every route there uses it's own flock to coordinate across processes, so this seems redundant?

@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Feb 11, 2025
@zanieb zanieb requested review from ibraheemdev and konstin and removed request for ibraheemdev February 11, 2025 14:42
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's hard to follow along if we covered all paths since we have no api-level connection between acquiring a lock and doing operations that need that lock acquired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants